-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looks like UIDropDownMenu_StopCounting and UIDropDownMenu_StartCounting were removed in 8.3 #32
Comments
I don't really mess with dropdowns, maybe @sylvanaar or @Pazza can look at that one. |
I haven't been keeping up over the years with the changes they have been making. Could you test and see what happens if you comment out that line? From looking at the diff quickly I can't see a replacement of that call, just its removal. Let me know if it things still behave. |
I removed these 2 lines (because the second gives an error too)
Errors are gone, drop-down menu still works perfectly... |
Thanks for confirming that. Can I assume this was only removed in Retail? |
That's possibly been broken for a long time, so it'd affect classic too since it's based off retail 8.1.5. it needs testing, so don't assume EDIT, oh op saays it's an 8.3 change so maybe not broken in classic YET. but eventually classic is supposed to migrate to 9.0 so it's probably better to rework |
Thanks @MysticalOS ... I think better to check for existence of _G.UIDropDownMenu_StopCounting, if so, then it'll keep executing that code. It was too long ago to remember why I had to put it in there. |
tomrus88/BlizzardInterfaceCode@31471cf#diff-b972302a6aed3ea5188d0216a191df25f154b40001deb441256d2c0247ebadeb
so
wow-instant-messenger/Sources/Options/OptionsTookKit.lua
Line 628 in e5d6f47
The text was updated successfully, but these errors were encountered: