Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like UIDropDownMenu_StopCounting and UIDropDownMenu_StartCounting were removed in 8.3 #32

Open
dartraiden opened this issue Oct 17, 2020 · 7 comments

Comments

@dartraiden
Copy link

tomrus88/BlizzardInterfaceCode@31471cf#diff-b972302a6aed3ea5188d0216a191df25f154b40001deb441256d2c0247ebadeb

so

f.scroll:SetScript("OnEnter", function(self) _G.UIDropDownMenu_StopCounting(self:GetParent()) end);
throws an error on new message sound drop-down menu opening in addon settings

@MysticalOS
Copy link
Collaborator

I don't really mess with dropdowns, maybe @sylvanaar or @Pazza can look at that one.

@Pazza
Copy link
Collaborator

Pazza commented Nov 5, 2020

I haven't been keeping up over the years with the changes they have been making. Could you test and see what happens if you comment out that line? From looking at the diff quickly I can't see a replacement of that call, just its removal. Let me know if it things still behave.

@dartraiden
Copy link
Author

dartraiden commented Nov 6, 2020

I removed these 2 lines (because the second gives an error too)

    f.scroll:SetScript("OnEnter", function(self) _G.UIDropDownMenu_StopCounting(self:GetParent()) end);
    f.scroll:SetScript("OnLeave", function(self) _G.UIDropDownMenu_StartCounting(self:GetParent()) end);

Errors are gone, drop-down menu still works perfectly...

@Pazza
Copy link
Collaborator

Pazza commented Nov 7, 2020

Thanks for confirming that. Can I assume this was only removed in Retail?

@MysticalOS
Copy link
Collaborator

MysticalOS commented Nov 7, 2020

That's possibly been broken for a long time, so it'd affect classic too since it's based off retail 8.1.5. it needs testing, so don't assume

EDIT, oh op saays it's an 8.3 change so maybe not broken in classic YET. but eventually classic is supposed to migrate to 9.0 so it's probably better to rework

@Pazza
Copy link
Collaborator

Pazza commented Nov 7, 2020

Thanks @MysticalOS ... I think better to check for existence of _G.UIDropDownMenu_StopCounting, if so, then it'll keep executing that code. It was too long ago to remember why I had to put it in there.

@dartraiden dartraiden changed the title Lools like UIDropDownMenu_StopCounting and UIDropDownMenu_StartCounting were removed in 8.3 Looks like UIDropDownMenu_StopCounting and UIDropDownMenu_StartCounting were removed in 8.3 Nov 7, 2020
@dartraiden
Copy link
Author

dartraiden commented Nov 7, 2020

Hmmm, I don't know why... but this menu looks like this on my main character (retail) - many items + scrollbars

Wow_JhDANvqLyl

and like this on all other characters (Retail + Classic) - only few items, so no scrollbar

vqnqkwmv5S

Errors appear only when using menu scrollbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants