Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do some basic linting of the PR description #67

Open
asmeurer opened this issue Jun 13, 2019 · 0 comments
Open

Do some basic linting of the PR description #67

asmeurer opened this issue Jun 13, 2019 · 0 comments

Comments

@asmeurer
Copy link
Member

In addition to the release notes, we can do some basic linting of the PR description. These wouldn't be things that would fail the build, but would hopefully guide people to writing better descriptions. Some things we can check

  • Warn if there is no "fixes #1234" in the description (but say it's OK if there is no corresponding issue)
  • Warn if the PR title contains an issue number
  • Suggest people to manually post a reference to the PR on the issue
  • Make sure there are no commits in the PR that add large files, or add junk files

Any other ideas?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asmeurer