From 88339261b1b424fa6ce0dd6250f92de570344a15 Mon Sep 17 00:00:00 2001
From: Arian van Putten <arian.vanputten@gmail.com>
Date: Fri, 12 Jul 2024 18:54:26 +0200
Subject: [PATCH] more restructuring

---
 journal.go             | 13 ++++-----
 journal_test.go        | 61 ++++++++++++++++++++++++++++++++++++++++++
 journal_writer.go      |  7 +++--
 journal_writer_test.go |  2 +-
 4 files changed, 72 insertions(+), 11 deletions(-)

diff --git a/journal.go b/journal.go
index 1a17423..6ffdb88 100644
--- a/journal.go
+++ b/journal.go
@@ -10,10 +10,10 @@ import (
 	"strconv"
 )
 
-type Priority int
+type priority int
 
 const (
-	priEmerg Priority = iota
+	priEmerg priority = iota
 	priAlert
 	priCrit
 	priErr
@@ -30,7 +30,7 @@ const (
 	LevelEmergency slog.Level = slog.LevelError + 3
 )
 
-func levelToPriority(l slog.Level) Priority {
+func levelToPriority(l slog.Level) priority {
 	switch l {
 	case slog.LevelDebug:
 		return priDebug
@@ -46,14 +46,15 @@ func levelToPriority(l slog.Level) Priority {
 		return priCrit
 	case LevelAlert:
 		return priAlert
+	case LevelEmergency:
+		return priEmerg
 	default:
-		panic("unreachable")
+		panic("invalid log level")
 	}
 }
 
 type Options struct {
 	Level slog.Leveler
-	Addr  string // Address of the journal socket. If not set defaults to /run/systemd/journal/socket. This is useful for testing.
 }
 
 type Handler struct {
@@ -76,7 +77,7 @@ func NewHandler(opts *Options) (*Handler, error) {
 		h.opts.Level = slog.LevelInfo
 	}
 
-	w, err := newJournalWriter(h.opts.Addr)
+	w, err := newJournalWriter()
 	if err != nil {
 		return nil, err
 	}
diff --git a/journal_test.go b/journal_test.go
index ee4f2ab..faa3c7d 100644
--- a/journal_test.go
+++ b/journal_test.go
@@ -8,6 +8,7 @@ import (
 	"log/slog"
 	"net"
 	"os"
+	"strconv"
 	"strings"
 	"syscall"
 	"testing"
@@ -258,5 +259,65 @@ func TestCanWriteMessageToSocket(t *testing.T) {
 		}
 
 	})
+}
+
+func TestNewlineBehaviour(t *testing.T) {
+
+	buf := new(bytes.Buffer)
+	handler, err := NewHandler(nil)
+	handler.w = buf
+	if err != nil {
+		t.Fatal("Error creating new handler")
+	}
+	multiline := "Hello, World!\nI am a multline\nstring"
+	record := slog.NewRecord(time.Now(), slog.LevelInfo, multiline, 0)
+	record.AddAttrs(slog.Attr{Key: "key", Value: slog.StringValue("value")})
+
+	if err := handler.Handle(context.TODO(), record); err != nil {
+		t.Fatal(err)
+	}
+
+	kv, err := deserializeKeyValue(buf)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if kv["MESSAGE"] != multiline {
+		t.Error("Unexpected message")
+	}
+
+}
+
+func TestLogLevels(t *testing.T) {
+	buf := new(bytes.Buffer)
+	handler, err := NewHandler(nil)
+	handler.w = buf
+	if err != nil {
+		t.Fatal("Error creating new handler")
+	}
+
+	priorities := map[slog.Level]priority{
+		slog.LevelDebug: priDebug,
+		slog.LevelInfo:  priInfo,
+		LevelNotice:     priNotice,
+		slog.LevelWarn:  priWarning,
+		slog.LevelError: priErr,
+		LevelCritical:   priCrit,
+		LevelAlert:      priAlert,
+		LevelEmergency:  priEmerg,
+	}
+
+	for level, priority := range priorities {
+		if err := handler.Handle(context.TODO(), slog.Record{Level: level, Message: "Hello, World!"}); err != nil {
+			t.Error(err)
+		}
+		kv, err := deserializeKeyValue(buf)
+		if err != nil {
+			t.Fatal(err)
+		}
+		if kv["PRIORITY"] != strconv.Itoa(int(priority)) {
+			t.Error("Unexpected priority", kv, priority, int(level))
+		}
+		buf.Reset()
+	}
 
 }
diff --git a/journal_writer.go b/journal_writer.go
index 29cbbdb..f6806bc 100644
--- a/journal_writer.go
+++ b/journal_writer.go
@@ -16,10 +16,9 @@ type journalWriter struct {
 	conn *net.UnixConn
 }
 
-func newJournalWriter(path string) (*journalWriter, error) {
-	if path == "" {
-		path = "/run/systemd/journal/socket"
-	}
+const path = "/run/systemd/journal/socket"
+
+func newJournalWriter() (*journalWriter, error) {
 	// The "net" library in Go really wants me to either Dial or Listen a UnixConn,
 	// which would respectively bind() an address or connect() to a remote address,
 	// but we want neither. We want to create a datagram socket and write to it directly
diff --git a/journal_writer_test.go b/journal_writer_test.go
index aeccf17..c650575 100644
--- a/journal_writer_test.go
+++ b/journal_writer_test.go
@@ -5,7 +5,7 @@ import (
 )
 
 func TestJournalWriter(t *testing.T) {
-	_, err := newJournalWriter("")
+	_, err := newJournalWriter()
 	if err != nil {
 		t.Fatal(err)
 	}