Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The OUTPUT panel opens automatically in workspaces where textlint is not installed. #66

Open
azu opened this issue Jul 16, 2023 · 3 comments · May be fixed by #67
Open

The OUTPUT panel opens automatically in workspaces where textlint is not installed. #66

azu opened this issue Jul 16, 2023 · 3 comments · May be fixed by #67

Comments

@azu
Copy link
Contributor

azu commented Jul 16, 2023

If vscode-textlint is installed, the OUTPUT panel will automatically open if you open a workspace that does not use textlint.

This appears to be due to an error output from the extension, which causes the OUTPUT panel to open.
However, this is not an error because you are not actually using textlint.

Therefore, it would be correct to make it a Warning or Info instead of an error log.

Reproduce

  1. Install vscode-textlint
  2. Open non-textlint project
  3. Show "OUTPUT" automaticaly
image
@azu azu linked a pull request Jul 16, 2023 that will close this issue
Open
@piranna
Copy link

piranna commented Aug 30, 2023

Related to this, I'm getting ERROR outputs because the textlint executable is not found, both in the project or globally. I think that if .textlint file is not found at all, it should not try to find the binary either, because the project is not making using textlint anyway.

@piranna
Copy link

piranna commented Oct 12, 2023

Any update on this? How can we move it forward besides remove the extension? This issue is very annoying... :-(

@piranna
Copy link

piranna commented Mar 10, 2024

Related to this, I'm getting ERROR outputs because the textlint executable is not found, both in the project or globally. I think that if .textlint file is not found at all, it should not try to find the binary either, because the project is not making using textlint anyway.

What I meant with that, is that in addition of the output panel being shown by using error instead of warning, the actual issue provoquing that is textlint executable is not found, that can be considered that's actually an error, but if there's no .textlint file, that's a totally acceptable use case that should show a warning instead, but the executable should not be looked at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use Status.WARN instead of ERROR azu/vscode-textlint
2 participants
@azu @piranna