Deprecate upsert with a key (from tarantool 1.6.6) #248
Labels
backlog
code health
Improve code readability, simplify maintenance and so on
enhancement
good first issue
Good for newcomers
prio1
Tarantool-java version: 1.9.3.
Cited from Tarantool 1.6.7 release notes:
See also tarantool/tarantool#1070
The connector provides
upsert()
method with akey
argument:tarantool-java/src/main/java/org/tarantool/AbstractTarantoolOps.java
Lines 39 to 41 in 56c28a3
This is harmless, because those arguments are packed into a map and deprecated
key
field is ignored by tarantool 1.6.7 and above. However this API can confuse a user.I propose to overload
upsert
method w/okey
argument to don't bother a user with providing some value forkey
. This will also save some CPU cycles on encoding a request and several bytes in outgoing packets.We also should cleanly state in javadoc that the old
upsert
method is deprecated and should be used only for tarantool 1.6.6 and below. We cannot remove the method, because the connector should be backward compatible.The text was updated successfully, but these errors were encountered: