You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TrombLoader added a new feature that prevents charts from loading if they are missing a field or have invalid json format. This is a great feature but it only takes few invalid charts (8 in my case) to make the loading time nearly twice as long.
Reproducible?
Easily. Simply create a faulty chart and copy it a few times then compare loading time.
Issue
For me its not too big of a deal since I can delete the chart that are displayed in the console, but for a regular user they may never notice that some of their charts aren't loading correctly. Its fair to assume most users won't have the bepinex console enabled or won't look at their logs so finding an alternative is probably required for invalid charts.
Example of warning message from invalid chart:
The text was updated successfully, but these errors were encountered:
Game Version: TC 1.17B
TrombLoader Version: 2.2.1
Description
TrombLoader added a new feature that prevents charts from loading if they are missing a field or have invalid json format. This is a great feature but it only takes few invalid charts (8 in my case) to make the loading time nearly twice as long.
Reproducible?
Easily. Simply create a faulty chart and copy it a few times then compare loading time.
Issue
For me its not too big of a deal since I can delete the chart that are displayed in the console, but for a regular user they may never notice that some of their charts aren't loading correctly. Its fair to assume most users won't have the bepinex console enabled or won't look at their logs so finding an alternative is probably required for invalid charts.
Example of warning message from invalid chart:
![image](https://private-user-images.githubusercontent.com/14132142/283991577-851f32df-ab8e-4ce8-8290-9fcdc7d1bdf1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjA5ODUsIm5iZiI6MTczOTI2MDY4NSwicGF0aCI6Ii8xNDEzMjE0Mi8yODM5OTE1NzctODUxZjMyZGYtYWI4ZS00Y2U4LTgyOTAtOWZjZGM3ZDFiZGYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA3NTgwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNhYzEzNzJiNzExNGVlZjY0NGYzYTEzYzFkMjliNWEwM2JiYjMwM2Y3NDYxNTdiZmEyYTU3ODNiMzI2NTgyN2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qpNsUMF7mj4Fhsh6Rx6VQuqiy96UVyXOoHjMrJzzI-M)
The text was updated successfully, but these errors were encountered: