From e85c4c499d335eb2a50718bf56118adcc95fb1d2 Mon Sep 17 00:00:00 2001
From: Kris Kowal <kris@cixar.com>
Date: Tue, 14 Jun 2022 16:54:16 -0700
Subject: [PATCH] Remove importMetaHook

Fixes #54

The importMetaHook is superfluous if static module records reveal needsImportMetaHook.  The decision of whether to build out importMeta can be made in loadHook.
---
 README.md | 28 +++++++++++++---------------
 1 file changed, 13 insertions(+), 15 deletions(-)

diff --git a/README.md b/README.md
index 244ad0a..34c439d 100644
--- a/README.md
+++ b/README.md
@@ -149,7 +149,11 @@ type Binding =
 // The bindings correspond to the equivalent `import` and `export` declarations
 // of an ECMAScript module.
 type SyntheticStaticModuleRecord = {
+  // Indicates the import and export bindings the module has
+  // between its module environment record, module exports namespace,
+  // and its dependencies.
   bindings?: Array<Binding>,
+
   // Initializes the module if it is imported.
   // Initialize may return a promise, indicating that the module uses
   // the equivalent of top-level-await.
@@ -159,9 +163,11 @@ type SyntheticStaticModuleRecord = {
     import?: (importSpecifier: string) => Promise<ModuleExportsNamespace>,
     importMeta?: Object
   }) => void,
+
   // Indicates that initialize needs to receive a dynamic import function that
   // closes over the referrer module specifier.
   needsImport?: boolean,
+
   // Indicates that initialize needs to receive an importMeta.
   needsImportMeta?: boolean,
 };
@@ -177,6 +183,13 @@ interface StaticModuleRecord {
   // Static module records reflect their bindings for information only.
   // Compartments use internal slots for the compiled code and bindings.
   bindings: Array<Binding>;
+
+  // Indicates that initialize needs to receive a dynamic import function that
+  // closes over the referrer module specifier.
+  needsImport?: boolean,
+
+  // Indicates that initialize needs to receive an importMeta.
+  needsImportMeta?: boolean,
 }
 
 // A ModuleDescriptor captures a static module record and per-compartment metadata.
@@ -198,8 +211,6 @@ type ModuleDescriptor =
   // * If the module descriptor has an `importMeta` property, the compartment
   //   will copy the own properties of the descriptor's `importMeta` over
   //   the compartment's `importMeta' using `[[Set]]`.
-  // * If the compartment has an `importMetaHook`, it will call
-  //   `importMetaHook(fullSpecifier, importMeta)`.
   // The compartment will then begin initializing the module.
   // The compartment memoizes a promise for the module exports namespace
   // that will be fulfilled at a time already defined in 262 for dynamic import.
@@ -346,19 +357,6 @@ type CompartmentConstructorOptions = {
   // Note: This name differs from the implementation of SES shim and a
   // prior revision of this proposal, where it is currently called `importHook`.
   loadHook?: (fullSpecifier: string) => Promise<ModuleDescriptor?>
-
-  // A ModuleDescriptor can have an `importMeta` property.
-  // The compartment assigns these properties over the true `import.meta`
-  // object for the module instance.
-  // That object in turn has a null prototype.
-  // However some properties of `import.meta` are too expensive for a host
-  // to instantiate for every module, like Node.js's `import.meta.resolve`,
-  // which can be avoided for modules that never utter `import.meta`
-  // in their sources.
-  // This hook gets called for any module that utters `import.meta`,
-  // so some work can be deferred until just before the compartment
-  // initializes the module.
-  importMetaHook?: (fullSpecifier: string, importMeta: Object) => void,
 };
 
 interface Compartment {