Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuietButton follow-ups (private component) #362

Open
theetrain opened this issue Jun 12, 2020 · 0 comments
Open

QuietButton follow-ups (private component) #362

theetrain opened this issue Jun 12, 2020 · 0 comments
Assignees
@janeszelag
Labels
priority: medium medium priority item status: DPA dev approved Component has accepted interface and acceptance criteria to be defined type: defect 🪲 Something isn't working as intended

Comments

@theetrain
Copy link
Contributor

Caused by #361

In an effort to get @tds/community-quiet-button into a stable state, also known as v1, let's address the following:

React component changes needed:

  • change px units to rem units
  • Recommend Box instead of hard-coded padding
  • use core-colours instead of hard-coded colours
  • Consider not using cursor: pointer, though that requires a holistic effort across all buttons
  • Can leverage core-button prop types for A11yContent
@theetrain theetrain added type: defect 🪲 Something isn't working as intended priority: medium medium priority item status: DPA dev approved Component has accepted interface and acceptance criteria to be defined labels Jun 12, 2020
@theetrain theetrain changed the title QuietButton follow-ups QuietButton follow-ups (private component) Jun 12, 2020
@janeszelag janeszelag self-assigned this Jul 29, 2020
@janeszelag janeszelag mentioned this issue Jul 29, 2020
Closed
@janeszelag janeszelag linked a pull request Jul 29, 2020 that will close this issue
Quiet button (private component) update #372
Closed
janeszelag pushed a commit that referenced this issue Oct 26, 2020
fix(community-quiet-button): address issue #362, fix bug
7e5cfbe
@janeszelag janeszelag mentioned this issue Oct 26, 2020
Merged
jraff pushed a commit that referenced this issue Nov 2, 2020
@jraff
fix(community-quiet-button): address issue #362, fix bug
d09fb28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janeszelag janeszelag

Labels
priority: medium medium priority item status: DPA dev approved Component has accepted interface and acceptance criteria to be defined type: defect 🪲 Something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Quiet button (private component) update telus/tds-community
2 participants
@theetrain @janeszelag