New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast: improvements, path to v1 #374

Open

5 tasks

theetrain opened this issue Jul 30, 2020 · 0 comments

Contributor

theetrain commented Jul 30, 2020 •

edited

Loading

This issue covers the Community Toast component. See #373. The following needs to be handled before it can be considered a 'v1' component.

Design considerations:

Are the colour combinations (ChevronLink on purple background) on brand?
What other usage criteria can be written? i.e. do not place next to other notifications

Code considerations (from #369)

♿ Add support for reduced animation
Remove any CSS containing font-size or font-family when TDS Typography components are being used
Rename instances of block-toast to toast or tds-toast for the data-id attribute
Refactor the variant prop to show up as a choice of strings (see comment)
Consider passing props down to the CTA/Link (see comment)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment