Fail to build against PG 13

[Vonng]

OS Environment: Rockylinux 8.9, with pgrx 0.12.9

$ rpmbuild --with debuginfo --define "pgmajorversion 13" -ba ~/rpmbuild/SPECS/vchord.spec
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.2t9cEU
+ umask 022
+ cd /home/vagrant/rpmbuild/BUILD
+ cd /home/vagrant/rpmbuild/BUILD
+ rm -rf vchord-0.1.0
+ /usr/bin/gzip -dc /home/vagrant/rpmbuild/SOURCES/vchord-0.1.0.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd vchord-0.1.0
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.6e2cej
+ umask 022
+ cd /home/vagrant/rpmbuild/BUILD
+ cd vchord-0.1.0
+ PATH=/usr/pgsql-13/bin:/home/vagrant/.cargo/bin:/home/vagrant/.cargo/bin:/home/vagrant/.local/bin:/home/vagrant/bin:/usr/share/Modules/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
+ cargo pgrx package -v
  2024-12-10T01:59:19.354081Z DEBUG cargo_pgrx::manifest: Found root package, manifest_path: /home/vagrant/rpmbuild/BUILD/vchord-0.1.0/Cargo.toml
    at /home/vagrant/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-pgrx-0.12.9/src/manifest.rs:64
    in cargo_pgrx::manifest::manifest_path
    in cargo_pgrx::command::package::execute

       Using PgConfig("pg13") and `pg_config` from /usr/pgsql-13/bin/pg_config
    Building extension with features pg13
     Running command "/home/vagrant/.rustup/toolchains/nightly-2024-11-19-x86_64-unknown-linux-gnu/bin/cargo" "build" "--lib" "--release" "--features" "pg13" "--no-default-features" "--message-format=json-render-diagnostics"
   Compiling proc-macro2 v1.0.92
   Compiling unicode-ident v1.0.14
   Compiling libc v0.2.168
   Compiling serde v1.0.215
   Compiling stable_deref_trait v1.2.0
   Compiling thiserror v1.0.69
   Compiling autocfg v1.4.0
   Compiling memchr v2.7.4
   Compiling cfg-if v1.0.0
   Compiling version_check v0.9.5
   Compiling syn v1.0.109
   Compiling once_cell v1.20.2
   Compiling serde_json v1.0.133
   Compiling libm v0.2.11
   Compiling litemap v0.7.4
   Compiling writeable v0.5.5
   Compiling equivalent v1.0.1
   Compiling hashbrown v0.15.2
   Compiling eyre v0.6.12
   Compiling byteorder v1.5.0
   Compiling num-traits v0.2.19
   Compiling icu_locid_transform_data v1.5.0
   Compiling icu_properties_data v1.5.0
   Compiling icu_normalizer_data v1.5.0
   Compiling thiserror v2.0.6
   Compiling smallvec v1.13.2
   Compiling quote v1.0.37
   Compiling indexmap v2.7.0
   Compiling syn v2.0.90
   Compiling getrandom v0.2.15
   Compiling utf16_iter v1.0.5
   Compiling utf8_iter v1.0.4
   Compiling shlex v1.3.0
   Compiling glob v0.3.1
   Compiling write16 v1.0.0
   Compiling indenter v0.3.3
   Compiling is_ci v1.2.0
   Compiling anyhow v1.0.94
   Compiling crossbeam-utils v0.8.20
   Compiling clang-sys v1.8.1
   Compiling winnow v0.6.20
   Compiling cc v1.2.3
   Compiling is-terminal v0.4.13
   Compiling proc-macro-error-attr v1.0.4
   Compiling regex-syntax v0.8.5
   Compiling percent-encoding v2.3.1
   Compiling owo-colors v4.1.0
   Compiling fnv v1.0.7
   Compiling ident_case v1.0.1
   Compiling strsim v0.11.1
   Compiling ucd-trie v0.1.7
   Compiling minimal-lexical v0.2.1
   Compiling nom v7.1.3
   Compiling form_urlencoded v1.2.1
   Compiling libloading v0.8.6
   Compiling supports-color v2.1.0
   Compiling supports-color v3.0.2
   Compiling rand_core v0.6.4
   Compiling proc-macro-error v1.0.4
   Compiling either v1.13.0
   Compiling bindgen v0.70.1
   Compiling ryu v1.0.18
   Compiling itoa v1.0.14
   Compiling yansi-term v0.1.2
   Compiling regex-automata v0.4.9
   Compiling tinyvec_macros v0.1.1
   Compiling unicode-width v0.1.14
   Compiling tinyvec v1.8.0
   Compiling crossbeam-epoch v0.9.18
   Compiling itertools v0.13.0
   Compiling annotate-snippets v0.9.2
   Compiling pathsearch v0.2.0
   Compiling cexpr v0.6.0
   Compiling bitflags v2.6.0
   Compiling same-file v1.0.6
   Compiling rustc-hash v1.1.0
   Compiling rayon-core v1.12.1
   Compiling home v0.5.9
   Compiling walkdir v2.5.0
   Compiling regex v1.11.1
   Compiling unicode-normalization v0.1.24
   Compiling crossbeam-deque v0.8.5
   Compiling synstructure v0.13.1
   Compiling darling_core v0.20.10
   Compiling unicode-bidi v0.3.17
   Compiling unicode-segmentation v1.12.0
   Compiling fixedbitset v0.4.2
   Compiling paste v1.0.15
   Compiling convert_case v0.6.0
   Compiling petgraph v0.6.5
   Compiling idna v0.5.0
   Compiling zerofrom-derive v0.1.5
   Compiling yoke-derive v0.7.5
   Compiling zerovec-derive v0.10.3
   Compiling displaydoc v0.2.5
   Compiling serde_derive v1.0.215
   Compiling icu_provider_macros v1.5.0
   Compiling zerofrom v0.1.5
   Compiling thiserror-impl v1.0.69
   Compiling yoke v0.7.5
   Compiling thiserror-impl v2.0.6
   Compiling zerocopy-derive v0.7.35
   Compiling darling_macro v0.20.10
   Compiling zerovec v0.10.4
   Compiling darling v0.20.10
   Compiling validator_derive v0.18.2
   Compiling zerocopy v0.7.35
   Compiling tinystr v0.7.6
   Compiling icu_locid v1.5.0
   Compiling icu_collections v1.5.0
   Compiling pest v2.7.15
   Compiling ppv-lite86 v0.2.20
   Compiling icu_provider v1.5.0
   Compiling rand_chacha v0.3.1
   Compiling icu_locid_transform v1.5.0
   Compiling icu_properties v1.5.1
   Compiling semver-parser v0.10.3
   Compiling rand v0.8.5
   Compiling semver v0.11.0
   Compiling rustc_version v0.3.3
   Compiling rand_distr v0.4.3
   Compiling detect_macros v0.0.0 (https://github.com/tensorchord/pgvecto.rs.git?branch=rabbithole-2#29df8b43)
   Compiling cee-scape v0.2.0
   Compiling icu_normalizer v1.5.0
   Compiling idna_adapter v1.2.0
   Compiling idna v1.0.3
   Compiling bytemuck v1.20.0
   Compiling rustix v0.38.42
   Compiling toml_datetime v0.6.8
   Compiling serde_spanned v0.6.8
   Compiling toml_edit v0.22.22
   Compiling url v2.5.4
   Compiling radium v0.7.0
   Compiling unescape v0.1.0
   Compiling pgrx-sql-entity-graph v0.12.9
   Compiling rayon v1.10.0
   Compiling validator v0.18.1
   Compiling half v2.4.1
   Compiling toml v0.8.19
   Compiling cargo_toml v0.19.2
   Compiling safe_arch v0.7.2
   Compiling detect v0.0.0 (https://github.com/tensorchord/pgvecto.rs.git?branch=rabbithole-2#29df8b43)
   Compiling atomic-traits v0.3.0
   Compiling base_macros v0.0.0 (https://github.com/tensorchord/pgvecto.rs.git?branch=rabbithole-2#29df8b43)
   Compiling pgrx-pg-config v0.12.9
   Compiling ptr_meta_derive v0.1.4
   Compiling pgrx-bindgen v0.12.9
   Compiling matrixmultiply v0.3.9
   Compiling ahash v0.7.8
   Compiling typenum v1.17.0
   Compiling log v0.4.22
   Compiling linux-raw-sys v0.4.14
   Compiling tap v1.0.1
   Compiling bytecheck v0.6.12
   Compiling heapless v0.8.0
   Compiling pgrx-macros v0.12.9
   Compiling wyz v0.5.1
   Compiling base v0.0.0 (https://github.com/tensorchord/pgvecto.rs.git?branch=rabbithole-2#29df8b43)
   Compiling ptr_meta v0.1.4
   Compiling wide v0.7.30
   Compiling enum-map-derive v0.17.0
   Compiling bytecheck_derive v0.6.12
   Compiling pgrx-pg-sys v0.12.9
   Compiling num-complex v0.4.6
   Compiling approx v0.5.1
   Compiling num-integer v0.1.46
   Compiling memmap2 v0.9.5
   Compiling hash32 v0.3.1
   Compiling simdutf8 v0.1.5
   Compiling sptr v0.3.2
   Compiling rawpointer v0.2.1
   Compiling half v1.8.3
   Compiling seahash v4.1.0
   Compiling rend v0.4.2
   Compiling funty v2.0.0
   Compiling serde_cbor v0.11.2
   Compiling bitvec v1.0.1
   Compiling simba v0.9.0
   Compiling num-rational v0.4.2
   Compiling common v0.0.0 (https://github.com/tensorchord/pgvecto.rs.git?branch=rabbithole-2#29df8b43)
   Compiling enum-map v2.7.3
   Compiling nalgebra-macros v0.2.2
   Compiling uuid v1.11.0
   Compiling smawk v0.3.2
   Compiling rkyv v0.7.45
   Compiling k_means v0.0.0 (https://github.com/tensorchord/pgvecto.rs.git?branch=rabbithole-2#29df8b43)
   Compiling hashbrown v0.12.3
   Compiling rkyv_derive v0.7.45
   Compiling nalgebra v0.33.0
   Compiling quantization v0.0.0 (https://github.com/tensorchord/pgvecto.rs.git?branch=rabbithole-2#29df8b43)
   Compiling pgrx v0.12.9
   Compiling pgrx-catalog v0.1.0
   Compiling vchord v0.1.0 (/home/vagrant/rpmbuild/BUILD/vchord-0.1.0)
error[E0061]: this function takes 5 arguments but 4 arguments were supplied
   --> src/vchordrq/index/am.rs:672:9
    |
672 |           algorithm::insert::insert(
    |  _________^^^^^^^^^^^^^^^^^^^^^^^^^-
673 | |             unsafe { Relation::new(index) },
674 | |             pointer,
675 | |             vector.into_vec(),
676 | |             opfamily.distance_kind(),
677 | |         );
    | |_________- argument #5 of type `bool` is missing
    |
note: function defined here
   --> src/vchordrq/algorithm/insert.rs:14:8
    |
14  | pub fn insert(
    |        ^^^^^^
15  |     relation: Relation,
    |     ------------------
16  |     payload: Pointer,
    |     ----------------
17  |     vector: Vec<f32>,
    |     ----------------
18  |     distance_kind: DistanceKind,
    |     ---------------------------
19  |     in_building: bool,
    |     -----------------
help: provide the argument
    |
672 |         algorithm::insert::insert(unsafe { Relation::new(index) }, pointer, vector.into_vec(), opfamily.distance_kind(), /* bool */);
    |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

For more information about this error, try `rustc --explain E0061`.
error: could not compile `vchord` (lib) due to 1 previous error
error: Bad exit status from /var/tmp/rpm-tmp.6e2cej (%build)


RPM build errors:

[kemingy]

I think #63 doesn't fix pg13. cc @usamoi

Do we plan to support pg13? @VoVAllen

[usamoi]

#63 fixes pg13 but CI is disabled on it so it breaks later