From 45e6ccc464144fbfb7ac0c4812238bb012844c48 Mon Sep 17 00:00:00 2001
From: Peter Luitjens <43619525+busma13@users.noreply.github.com>
Date: Tue, 14 Jan 2025 16:36:46 -0700
Subject: [PATCH] [workspace] fix release automation - use personal access
 token, log slack api failures (#3905)

This PR makes the following changes:
- Update `publish-master.yml` workflow to use the github Terascope
Release App with `actions/create-github-app-token@v1` to create an
access token. The previous token used cannot trigger a secondary
workflow.
- Log slack API failures for debugging purposes.
---
 .github/workflows/publish-master.yml | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/publish-master.yml b/.github/workflows/publish-master.yml
index 9543bf2e71c..a8598ba02aa 100644
--- a/.github/workflows/publish-master.yml
+++ b/.github/workflows/publish-master.yml
@@ -84,11 +84,19 @@ jobs:
             echo "version_updated=false" >> $GITHUB_OUTPUT
           fi
 
+      - name: Generate a token
+        if: steps.version_check.outputs.version_updated == 'true'
+        id: generate-token
+        uses: actions/create-github-app-token@v1
+        with:
+          app-id: ${{ vars.RELEASES_APP_ID }}
+          private-key: ${{ secrets.RELEASES_PRIVATE_KEY }}
+
       - name: Create Release
         if: steps.version_check.outputs.version_updated == 'true'
         uses: softprops/action-gh-release@v2
         with:
-          token: ${{ secrets.GITHUB_TOKEN }}
+          token: ${{ steps.generate-token.outputs.token }}
           prerelease: true
           tag_name: ${{ steps.version_check.outputs.tag }}
           name: ${{ steps.version_check.outputs.tag }}
@@ -96,6 +104,7 @@ jobs:
 
       - name: Announce release in Slack releases channel
         if: steps.version_check.outputs.version_updated == 'true'
+        id: announce-release
         uses: slackapi/slack-github-action@v2.0.0
         with:
           method: chat.postMessage
@@ -103,9 +112,13 @@ jobs:
           payload: |
             channel: ${{ vars.SLACK_RELEASES_CHANNEL_ID }}
             text: |
-              "Teraslice version ${{ steps.version_check.outputs.tag }} has been released.
+              Teraslice version ${{ steps.version_check.outputs.tag }} has been released.
               Please review and revise the automated release notes:
-              https://github.com/terascope/teraslice/releases/tag/${{ steps.version_check.outputs.tag }}"
+              https://github.com/terascope/teraslice/releases/tag/${{ steps.version_check.outputs.tag }}
+
+      - name: Failed Announcement Response
+        if: ${{ steps.announce-release.outputs.ok == 'false' }}
+        run: echo "Slackbot API failure response - ${{ steps.announce-release.outputs.response }}"
 
   build-docs:
     if: github.event.pull_request.merged == true