From 49453c7707851879b47e50fb7cfcb6b30dc33517 Mon Sep 17 00:00:00 2001
From: Renato Rudnicki <renatojr@ciandt.com>
Date: Fri, 17 Jan 2025 17:52:47 -0300
Subject: [PATCH] fix lint

---
 3-networks-dual-svpc/modules/base_env/main.tf               | 2 +-
 3-networks-dual-svpc/modules/base_env/remote.tf             | 1 -
 .../modules/restricted_shared_vpc/README.md                 | 1 +
 .../modules/restricted_shared_vpc/variables.tf              | 6 ++++++
 .../modules/restricted_shared_vpc/main.tf                   | 2 +-
 5 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/3-networks-dual-svpc/modules/base_env/main.tf b/3-networks-dual-svpc/modules/base_env/main.tf
index c5679eea7..930d869a0 100644
--- a/3-networks-dual-svpc/modules/base_env/main.tf
+++ b/3-networks-dual-svpc/modules/base_env/main.tf
@@ -171,7 +171,7 @@ module "restricted_shared_vpc" {
 
   project_id                       = local.restricted_project_id
   project_number                   = local.restricted_project_number
-  production_restricted_project_id = local.production_restricted_project_id
+  production_project_id            = local.production_restricted_project_id
   environment_code                 = var.environment_code
   access_context_manager_policy_id = var.access_context_manager_policy_id
   restricted_services              = local.restricted_services
diff --git a/3-networks-dual-svpc/modules/base_env/remote.tf b/3-networks-dual-svpc/modules/base_env/remote.tf
index 80db5b34a..a768cdde5 100644
--- a/3-networks-dual-svpc/modules/base_env/remote.tf
+++ b/3-networks-dual-svpc/modules/base_env/remote.tf
@@ -26,7 +26,6 @@ locals {
   production_base_project_id       = data.terraform_remote_state.org.outputs.shared_vpc_projects["production"].base_shared_vpc_project_id
 }
 
-
 data "terraform_remote_state" "bootstrap" {
   backend = "gcs"
 
diff --git a/3-networks-dual-svpc/modules/restricted_shared_vpc/README.md b/3-networks-dual-svpc/modules/restricted_shared_vpc/README.md
index 3ad3b457d..4530eb09c 100644
--- a/3-networks-dual-svpc/modules/restricted_shared_vpc/README.md
+++ b/3-networks-dual-svpc/modules/restricted_shared_vpc/README.md
@@ -26,6 +26,7 @@
 | nat\_num\_addresses\_region2 | Number of external IPs to reserve for region 2 Cloud NAT. | `number` | `2` | no |
 | private\_service\_cidr | CIDR range for private service networking. Used for Cloud SQL and other managed services. | `string` | `null` | no |
 | private\_service\_connect\_ip | Internal IP to be used as the private service connect endpoint. | `string` | n/a | yes |
+| production\_project\_id | Project ID for Restricted Shared. | `string` | `""` | no |
 | project\_id | Project ID for Restricted Shared VPC. | `string` | n/a | yes |
 | project\_number | Project number for Restricted Shared VPC. It is the project INSIDE the regular service perimeter. | `number` | n/a | yes |
 | restricted\_dns\_project\_id | Project ID for DNS Restricted Shared. | `string` | `""` | no |
diff --git a/3-networks-dual-svpc/modules/restricted_shared_vpc/variables.tf b/3-networks-dual-svpc/modules/restricted_shared_vpc/variables.tf
index 27e733385..9753fc176 100644
--- a/3-networks-dual-svpc/modules/restricted_shared_vpc/variables.tf
+++ b/3-networks-dual-svpc/modules/restricted_shared_vpc/variables.tf
@@ -20,6 +20,12 @@ variable "restricted_dns_project_id" {
   default     = ""
 }
 
+variable "production_project_id" {
+  description = "Project ID for Restricted Shared."
+  type        = string
+  default     = ""
+}
+
 variable "target_name_server_addresses" {
   description = "List of IPv4 address of target name servers for the forwarding zone configuration. See https://cloud.google.com/dns/docs/overview#dns-forwarding-zones for details on target name servers in the context of Cloud DNS forwarding zones."
   type        = list(map(any))
diff --git a/3-networks-hub-and-spoke/modules/restricted_shared_vpc/main.tf b/3-networks-hub-and-spoke/modules/restricted_shared_vpc/main.tf
index bff9f77e1..4021a4dd4 100644
--- a/3-networks-hub-and-spoke/modules/restricted_shared_vpc/main.tf
+++ b/3-networks-hub-and-spoke/modules/restricted_shared_vpc/main.tf
@@ -20,7 +20,7 @@ locals {
   network_name                = "vpc-${local.vpc_name}"
   restricted_googleapis_cidr  = module.private_service_connect.private_service_connect_ip
   google_forward_source_range = "35.199.192.0/19"
-  advertised_ip               = var.environment_code == "p" ? [{ range = local.google_forward_source_range }, { range = local.restricted_googleapis_cidr }] : [{ range = local.restricted_googleapis_cidr}]
+  advertised_ip               = var.environment_code == "p" ? [{ range = local.google_forward_source_range }, { range = local.restricted_googleapis_cidr }] : [{ range = local.restricted_googleapis_cidr }]
 }
 
 /******************************************