Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --dns-endpoint in kubectl-wrapper #210

Open
michaelbannister opened this issue Jan 22, 2025 · 0 comments
Open

Support --dns-endpoint in kubectl-wrapper #210

michaelbannister opened this issue Jan 22, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@michaelbannister
Copy link

michaelbannister commented Jan 22, 2025

TL;DR

The internal kubectl-wrapper module uses gcloud container clusters get-credentials. GKE recently introduced DNS-based endpoints which essentially just needs the user to add the flag --dns-endpoint on that command.

Terraform Resources

module "kubectl" {
  source = "terraform-google-modules/gcloud/google//modules/kubectl-wrapper"

  project_id              = var.project_id
  cluster_name            = var.cluster_name
  cluster_location        = var.cluster_location
  use_dns_endpoint        = true # potential new variable
  kubectl_create_command  = "kubectl create deploy nginx --image=nginx"
  kubectl_destroy_command = "kubectl delete deploy nginx"
}

Detailed design

Additional information

No response

@michaelbannister michaelbannister added the enhancement New feature or request label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant