Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use map type for labels in modules/hub #1130

Open
justicel opened this issue Jan 20, 2022 · 1 comment
Open

Use map type for labels in modules/hub #1130

justicel opened this issue Jan 20, 2022 · 1 comment
Labels
enhancement New feature or request P4 low priority issues triaged Scoped and ready for work

Comments

@justicel
Copy link

TL;DR

All other resource types and TF modules I've run across for GCP use a map type when defining labels. Instead, the 'hub' submodule appears to require a comma separated string for labels. Instead, we should use Terraform to combine/concat the labels map in to the proper format that the script needs when it runs. This will reduce complexity and bugs when using inherited variables files.

Terraform Resources

No response

Detailed design

No response

Additional information

No response
@justicel justicel added the enhancement New feature or request label Jan 20, 2022
@morgante
Copy link
Contributor

This seems reasonable, though not a high priority. We would be happy to review a PR.

@morgante morgante added P4 low priority issues triaged Scoped and ready for work labels Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P4 low priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justicel @morgante