Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB SDK version Needs upgrade (upstream issue it seems, does not seem to affect functionality) #476

Closed
userlab-luisdeleon opened this issue Nov 14, 2023 · 15 comments
Labels
bug Something isn't working upstream Issue seems to be in upstream system not this lib

Comments

@userlab-luisdeleon
Copy link

🐛 Bug Report

in latest version
react-native-fbsdk-next: 12.1.1

image

I have installed the latest version when I integrate it and check the FB console I get this message
any ideas?

@AronBe
Copy link

AronBe commented Nov 14, 2023

Seeing the same

@mikehardy
Copy link
Collaborator

I think someone needs to propose a PR that integrates the latest SDK and confirm they have tested it and it works.
It's open source, you are a fully empowered developer, not just a powerless user waiting for someone to help you.
I'm happy to merge and release any reasonable PR if you can show you've tested it and it works

@mikehardy mikehardy added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 14, 2023
@jamesrogers93
Copy link

I'm seeing the same issue. Annoyingly this is blocking us from running Facebook ads.

A temporary fix might be to downgrade to use v11.3.0 as it uses FBSDK v15. (I believe this is a bug with FBSDK v16).

Will let you know if this works for me.

@jamesrogers93
Copy link

Now works after downgrading to v11.3.0

Before:
Screenshot 2023-11-21 at 12 33 01

After:
Screenshot 2023-11-21 at 14 02 23

@mikehardy
Copy link
Collaborator

@jamesrogers93 or....

I think someone needs to propose a PR that integrates the latest SDK and confirm they have tested it and it works.

@jamesrogers93
Copy link

I suggested it as a temporary fix, not a permanent fix.

@mikehardy
Copy link
Collaborator

No one wants to do the work to try to move things forward 😆
Not picking on you specifically, this is the tragedy of open source encapsulated in one single issue
Everyone interested, no one moving it forward. Eventually someone will really need it then it'll move

@CedYF

This comment was marked as duplicate.

@alzalabany
Copy link

feb 2024 :) still same issue

@mikehardy
Copy link
Collaborator

Still comments that don't advance anything but they generate notifications for everyone, smiley

@4yki
Copy link

4yki commented Feb 15, 2024

Seems like there is an issue with native facebook-android-sdk facebook/facebook-android-sdk#1191
No clear answers from contributors yet... Anyway there is nothing to do with RN package. I think this issue must be closed as it's not an actual library issue.
I don't use much functionality (just events tracking) so for me simple patch with downgraded SDK versions works. Not sure if it affects other features.

@mikehardy
Copy link
Collaborator

Nice find @4yki thanks for going upstream and looking there. I did my best upstream with a comment trying to move it forward for real, we'll see how it goes.

Agreed this is not a problem we can resolve here so I am going to close this but for anyone reading along that doesn't mean it is solved necessarily it just means there will be no change in the repository here related to the problem, so it doesn't help to keep it open here

If I'm wrong, can always reopen but please do your homework, search lists, check code, really try to understand things and advance them before posting comments. Just posting +1s and metoos is childish behavior in my opinion - generates notifications that have no content which is basically spam. Don't be that person. Thank you :-)

@mikehardy mikehardy added bug Something isn't working upstream Issue seems to be in upstream system not this lib and removed help wanted Extra attention is needed good first issue Good for newcomers labels Feb 16, 2024
@mikehardy mikehardy changed the title FB SDK version Needs upgrade FB SDK version Needs upgrade (upstream issue it seems, does not seem to affect functionality) Feb 16, 2024
@mikehardy mikehardy pinned this issue Feb 16, 2024
@vyancharuk
Copy link

@jamesrogers93 @alzalabany Is this issue still present in the latest SDK version, v13.0.0 (FB v17)?

@Anas-7
Copy link

Anas-7 commented Jul 10, 2024

@vyancharuk Yes it is still present. Downgrading to 11.3.0 fixed the Android issue but iOS is still stuck at 0.0.2

@i-ked-ii
Copy link

Now needs upgrade more than v17.0.0

Screenshot 2567-09-10 at 10 23 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Issue seems to be in upstream system not this lib
Projects
None yet
Development

No branches or pull requests

10 participants