Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual editor shortcode bug #58

Closed
frnsys opened this issue Apr 19, 2017 · 7 comments
Closed

Visual editor shortcode bug #58

frnsys opened this issue Apr 19, 2017 · 7 comments
Assignees
Labels

Comments

@frnsys
Copy link
Member

frnsys commented Apr 19, 2017

When using the visual editor for posts with [popover] shortcodes, line breaks get added for some reason?

@misfist
Copy link
Collaborator

misfist commented Apr 19, 2017

This is actually also in the plugin because we don't want shortcodes to stop workinig if the theme is changed.

This issue seems to be related to Shortcode UI, not the shortcode itself. Shortcode UI provides the interface to add the shortcode via fields and it renders it in the visual editor (so users can preview what it's going to look like [sort of]). When I disable shortcode UI, the shortcode no longer has p tags added when switching to the visual editor.

So, I'm wondering if you want to disable shortcode UI until I can figure out a solution?

BTW. I added a ticket for this wp-shortcake/shortcake#721

@frnsys
Copy link
Member Author

frnsys commented Apr 19, 2017

We can leave it for now -- we won't be using those popover shortcodes for a bit so it's not urgent. It would be nice eventually to have a solution though

@misfist
Copy link
Collaborator

misfist commented Apr 19, 2017

Not sure if this was clear. The shortcode works even when shortcode ui is disabled. So, if we disable shortcode ui, the shortcode will work without adding the p tags.

@frnsys
Copy link
Member Author

frnsys commented Apr 20, 2017

ah ok - when you get a chance then let's disable that for now

@misfist
Copy link
Collaborator

misfist commented Apr 20, 2017 via email

@frnsys
Copy link
Member Author

frnsys commented Apr 20, 2017

got it, deactivated it

@misfist
Copy link
Collaborator

misfist commented Apr 20, 2017

Moving this to core functionality since that's where the functionality lives.

thenewinquiry/tni-core-functionality#13

@misfist misfist closed this as completed Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants