Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Camera] Refactor/rework video recording #31

Closed
thmsbfft opened this issue Nov 28, 2016 · 1 comment
Closed

[Camera] Refactor/rework video recording #31

thmsbfft opened this issue Nov 28, 2016 · 1 comment
Assignees

Comments

@thmsbfft
Copy link
Owner

Video recording is still experimental (read: busted).
• It performs very badly on hidpi screens because each frame has to be saved to disc.
• Frames can drop because of disc accesses on resource intensive websites.
• FPS is not 100% reliable. Most videos seem to be playing slightly faster that what's recorded.

So far I see two ways of fixing it:

• Changing the API used to capture frames:
desktop-capturer seems promising, working with streams would eliminate disk access problems.

electron/desktop-capturer
Note: might change the way we choose to record mouse cursors or not. See #30.

• Record frames directly to a stream:
Would rely heavily on ffmpeg to do the hard work.

@thmsbfft thmsbfft added this to the 0.0.6 milestone Nov 28, 2016
@thmsbfft thmsbfft self-assigned this Nov 28, 2016
@thmsbfft thmsbfft removed this from the 0.0.6 milestone Feb 11, 2017
@thmsbfft
Copy link
Owner Author

thmsbfft commented Sep 6, 2017

Fixed in 0.2.0. Closing.

@thmsbfft thmsbfft closed this as completed Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant