Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TP-SDS (and potentially VSD) to improve quality/diversity #194

Open
yankeesong opened this issue Jun 29, 2023 · 3 comments
Open

Add TP-SDS (and potentially VSD) to improve quality/diversity #194

yankeesong opened this issue Jun 29, 2023 · 3 comments

Comments

@yankeesong
Copy link
Collaborator

yankeesong commented Jun 29, 2023

TP-SDS
This paper shows that using monotonically non-increasing time-sampling in diffusion models shows better results than uniform sampling. I can try to implement it.

@thuliu-yt16
Copy link
Collaborator

Of course, PR is welcome!

@yuanzhi-zhu
Copy link

yuanzhi-zhu commented Jun 30, 2023

@yankeesong I tried it with 2d experiments here https://github.com/yuanzhi-zhu/prolific_dreamer2d and found that Dreamtime only helps sds a bit but not vsd.

Would like to see your implementation!!

@yankeesong
Copy link
Collaborator Author

@yuanzhi-zhu I suspect this is because for SDS the diffusion is frozen whereas for VSD a LoRA is trained. If one trains the LoRA with TP (i.e. with non-uniform time sampling), they might introduce inductive bias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants