Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline images showing up as attachments in emails #816

Closed
MelissaAutumn opened this issue Jan 7, 2025 · 0 comments · Fixed by #817
Closed

Fix inline images showing up as attachments in emails #816

MelissaAutumn opened this issue Jan 7, 2025 · 0 comments · Fixed by #817
Assignees
Labels
bug Something isn't working M: Appointment Beta 3

Comments

@MelissaAutumn
Copy link
Member

Currently we attach inline images like any other image. This work well as long as the cid is referenced in the email, most clients will hide the image from the attachment list. (https://github.com/thunderbird/appointment/blob/main/backend/src/appointment/controller/mailer.py#L116)

However it seems k9mail/tfa looks for Content-Disposition: inline which seems good and correct. So we should probably mark inline images as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working M: Appointment Beta 3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant