Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run-on-blame ignoring standards file #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix run-on-blame ignoring standards file #44

wants to merge 2 commits into from

Conversation

lode
Copy link

@lode lode commented Jun 29, 2020

This fixes #40. I hope, I'm a bit unsure whether the path should first be unresolved to an absolute path, or whether that is not required.

Btw, I didn't get to run this locally so couldn't test if this works. If you have some contributing / local development advice, I'm open!

@lode
Copy link
Author

lode commented Jul 7, 2020

@tinovyatkin it would be great if you have time to look at this!

@lode
Copy link
Author

lode commented Aug 10, 2020

Ping @tinovyatkin I'd love your view on this if you have the space for it.

@fma-technologies
Copy link

@tinovyatkin Would you be able to merge this pull request please?

Thanks for figuring out the problem @lode!

@fma-technologies
Copy link

fma-technologies commented Sep 2, 2020

@lode Could we change phpcs.yml to this to test it?

uses: lode/action-php-codesniffer@patch-2

I tried doing that, but I still have no success on the scope: 'blame' mode.

Do you have any other ideas?

@thenabeel
Copy link

@fma-technologies Since author hasn't merged the code yet, I have fixed and published my own fork of it.
If you are facing this issue, you can use this in your yml file:
uses: thenabeel/action-phpcs@v8

@rssteffey
Copy link

@thenabeel Thank you so much for that fork! It got our PSR-12 + blame setup running perfectly. Shame this main repo seems to be dead, but I really appreciate you solving it @lode

@thenabeel
Copy link

@thenabeel Thank you so much for that fork! It got our PSR-12 + blame setup running perfectly. Shame this main repo seems to be dead, but I really appreciate you solving it @lode

@rssteffey I am glad it was useful for you!

@oojacoboo
Copy link

@tinovyatkin please merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not respecting standards file
5 participants