-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix run-on-blame ignoring standards file #44
base: master
Are you sure you want to change the base?
Conversation
@tinovyatkin it would be great if you have time to look at this! |
Ping @tinovyatkin I'd love your view on this if you have the space for it. |
@tinovyatkin Would you be able to merge this pull request please? Thanks for figuring out the problem @lode! |
@lode Could we change phpcs.yml to this to test it?
I tried doing that, but I still have no success on the Do you have any other ideas? |
@fma-technologies Since author hasn't merged the code yet, I have fixed and published my own fork of it. |
@thenabeel Thank you so much for that fork! It got our PSR-12 + blame setup running perfectly. Shame this main repo seems to be dead, but I really appreciate you solving it @lode |
@rssteffey I am glad it was useful for you! |
@tinovyatkin please merge this |
This fixes #40. I hope, I'm a bit unsure whether the path should first be unresolved to an absolute path, or whether that is not required.
Btw, I didn't get to run this locally so couldn't test if this works. If you have some contributing / local development advice, I'm open!