-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback handlers on nested routers returning 404 #2252
Comments
Does that code even compile? (can't check, on mobile) |
Yup, it compiles. Changing the fallback to |
I have independently reproduced this. |
@Protryon do you wanna share your repro or is it secret? 😅 |
It's not public, but the TL;DR was a nested router that had a route for |
I'm trying to do an upgrade from axum-0.6.11 to axum-0.6.20 and I noticed that the behavior we were relying on in 0.6.11, where a nested handler could designate a fallback, seems to not work in 0.6.20.
I've got a test case in this repository:
https://github.com/maxburke/axum-test
With axum-0.6.11,
curl -v http://localhost:3000/nest/
returns 200 + "Hello World", but with axum-0.6.20, the same curl command returns 404 + empty response.The text was updated successfully, but these errors were encountered: