-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Android projects #13
Comments
I think it might be a classpath issue. This plugin adds something to the classpath that makes existing plugins fail. A problem with Gradle, not with this plugin. |
I see the same bug
|
Since Android API 28 you have to use Gradle Plugin 3.2.0 to compile and Android app. |
@flasher297 not really sure what to do with that. Are you saying I need to update something? |
I released 1.61 now with some changes: https://github.com/tomasbjerre/gradle-scripts/commits/gradle5 Did that help? |
The error persists :/ |
I tried to build the repository and branch in this issue. Got the same error with |
I've encountered the same issue in Android project when using Gradle plugin 3.2.0 or newer. |
I'm using Gradle 5.4.1 without problems here: https://github.com/tomasbjerre/violations-lib |
@tomasbjerre The issue still occurs unfortunately. Have you been able to test with an Android Project? There definitely appears to be a conflict due to the presence of the Android Gradle Plugin.
Hope this helps! |
Yes I have been able to test but not reproduce the problem. An open repository with minimal code that shows the problem would be great. |
@tomasbjerre Here is a public repository with a fresh Android project, it is currently displaying the mentioned issue. |
I am able to create a changelog if I change the code like this:
And run:
|
Hmmm, I agree that looks to be working. But I am still seeing Gradle Project sync failures while the plugin is present in the project. Would it be possible for that to be resolved? |
What does "Gradle Project sync failures" mean? |
I don't know what that is. Perhaps try:
|
I ran
Does that help? |
That does not happen to me. I also cannot see how this plugin can cause that. ✔ ~/workspace/Fresh-Android-Project [implement-git-changelog {origin/implement-git-changelog}|✚ 2…1]
19:01 $ ./gradlew assemble --stacktrace
To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/5.4.1/userguide/gradle_daemon.html.
Daemon will be stopped at the end of the build stopping after processing
BUILD SUCCESSFUL in 5s
✔ ~/workspace/Fresh-Android-Project [implement-git-changelog {origin/implement-git-changelog}|✚ 2…1]
19:01 $ ./gradlew clean assemble --stacktrace
To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/5.4.1/userguide/gradle_daemon.html.
Daemon will be stopped at the end of the build stopping after processing
BUILD SUCCESSFUL in 4s
2 actionable tasks: 2 up-to-date
✔ ~/workspace/Fresh-Android-Project [implement-git-changelog {origin/implement-git-changelog}|✚ 2…1] |
Just a small heads up here. This Gradle plugin is pulling in several dependencies that are clashing with the one needed by Android Gradle plugin (see #21). Specifically is pulling in To overcome this you can exclude the transitive dependency:
Still I'm unsure how a changelog plugin needs a library for bytecode manipulation ¯\(ツ)/¯ |
Transitive. And probably from jgit, I will check later. |
Hi,
I have tried to integrate the latests version (1.6.0) with my Android project and I got this error:
You can check this behavior on this branch and the output
The text was updated successfully, but these errors were encountered: