Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to switch to next/prev image with arrow keys #110

Open
reverse123 opened this issue Aug 18, 2023 · 5 comments
Open

Ability to switch to next/prev image with arrow keys #110

reverse123 opened this issue Aug 18, 2023 · 5 comments

Comments

@reverse123
Copy link

Please add the ability to dynamically switch to the next/prev image with arrow keys.
There is some album functionality, but looks like it is tied to predefined websites.
Thanks.

@tophf
Copy link
Owner

tophf commented Aug 18, 2023

This functionality was always present when viewing galleries and it works for me. Which sites don't work for you?

@tophf tophf closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2023
@reverse123
Copy link
Author

reverse123 commented Aug 31, 2023

For me personally when I click left/right arrow keys nothing happens.
I am talking about using it not only with sites where the script detects galleries, but any image sets. When the user presses the right arrow key on the site with no gallery detected, the script should find the closest next image that can be enlarged and show its popup.
This will be very universal. This will work with almost all imageboards, boorus and so on at once.

@tophf tophf reopened this Aug 31, 2023
@reverse123
Copy link
Author

Guess I will write an userscript-extension for this. Maybe you will include this functionality in your great script.

@tophf
Copy link
Owner

tophf commented Sep 1, 2023

I doubt I'll implement it because it doesn't seem trivial and many sites need complex rules, there may be also false positives for auxilliary images like avatars, icons. The idea is interesting though, so I'm keeping it open.

@reverse123
Copy link
Author

The structure of the parent DOM elements of the popped up image should be similar to the next one. Image size should also be checked if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants