Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckUpdates<true>: verify m_iter->seek_lower_bound(key) failed #1

Open
rockeet opened this issue Oct 24, 2022 · 1 comment
Open

CheckUpdates<true>: verify m_iter->seek_lower_bound(key) failed #1

rockeet opened this issue Oct 24, 2022 · 1 comment

Comments

@rockeet
Copy link
Contributor

rockeet commented Oct 24, 2022

MyTopling MTR test failed with CheckUpdates: verify m_iter->seek_lower_bound(key) failed

@rockeet
Copy link
Contributor Author

rockeet commented Oct 24, 2022

This is caused by MyRocks/RocksDB calling WBWI::Clear() without delete existing iterators.

Fixes: link all WBWI Iterators in with a linked list, and set all iterators invalid in ClearIndex.

I had first add WBWI Iterators in a valvec, then I realized linked list is a more suitable choice.

Relevant commits
131ab66 set all iters invalid on ClearIndex() - use linked list instead of vector
7ba77be set all iters invalid on ClearIndex() - this version use vector(valvec)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant