Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for let &makeprg in Dispatch makeprg detection in compiler file #354

Open
Konfekt opened this issue Nov 7, 2024 · 3 comments
Open

Comments

@Konfekt
Copy link

Konfekt commented Nov 7, 2024

The following idiom in a compiler/*.vim file

let &l:makeprg = 'm'
exe 'CompilerSet makeprg='..escape(&l:makeprg, ' "')

should work fine (maybe requiring further escapes!?), but is not accounted for by :Dispatch.
I suspect a regex searches for makeprg=\w+ ?

@Konfekt
Copy link
Author

Konfekt commented Nov 7, 2024

One can work around by " CompilerSet makeprg=m comments, but that seems rather something to be fixed on Dispatch's side

@tpope
Copy link
Owner

tpope commented Nov 7, 2024

The following idiom in a compiler/*.vim file

Can you show me some real world examples?

One can work around by " CompilerSet makeprg=m comments, but that seems rather something to be fixed on Dispatch's side

Fixed how? Seems well beyond the limits of what can be accomplished with regex.

@Konfekt
Copy link
Author

Konfekt commented Nov 7, 2024

Can you show me some real world examples?

https://github.com/vim/vim/pull/15804/files , https://github.com/vim/vim/pull/16007/files and https://github.com/vim/vim/pull/16001/files

I sneaked in besaid comment just in case

Fixed how? Seems well beyond the limits of what can be accomplished with regex.

Maybe something like \v<makeprg>\W+=\W+<m> if not too slow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants