Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects are being culled when they should not be (1.20.1 forge, 1.7.2) #186

Open
LittleManDiscord opened this issue Jan 15, 2025 · 4 comments

Comments

@LittleManDiscord
Copy link

Some objects and particles are culled at certain angles when they should not be. I tested this with other performance mods at the time, namely Embeddium, Canary, Starlight, and ModernFix. Objects and particles at certain angles seem to bug out. For example, minecarts with chests will cull when looked at from certain angles.
2025-01-14_19 12 17
2025-01-14_19 12 20

@tr7zw
Copy link
Owner

tr7zw commented Jan 15, 2025

That's not Entityculling. Either the minecart+chest is gone or neither, not just the minecart. Particles are not touched at all by EntityCulling. The angle is also not used at all, so rotating the camera has 0 impact on what the mod culls or doesn't cull.

@LittleManDiscord
Copy link
Author

I see. Sorry then, I'll go take a further look to see what's going on.

@tr7zw
Copy link
Owner

tr7zw commented Jan 15, 2025

You can bind a debug key in the hotkeys to turn on/off the mod during gameplay, that should show that it stays hidden. In both screenshots there seem also to be weirdly not rendered chunks?
grafik

@LittleManDiscord
Copy link
Author

LittleManDiscord commented Jan 15, 2025

The rendered chunks is due to the fact that my chunk loading speed was kind of slow and I flew to a high location

I'm taking your word that the mod itself isn't causing the issue but I believe it's another performance mod that is messing with entityculling because disabling it through key binds fixed the issue.

EDIT: I think the issue is being caused by some weird interaction between this mod and either Entity Model Features or Entity Texture Features but it's been fixed
2025-01-15_13 06 51
2025-01-15_13 07 02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants