Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default name conflicts with github.com/prometheus/client_golang/prometheus/promhttp #3

Open
mhansen opened this issue Jun 22, 2020 · 0 comments

Comments

@mhansen
Copy link
Contributor

mhansen commented Jun 22, 2020

Hi, this looks like a cool package! I've imported it and using it. One piece of feedback is that the name conflicts with the commonly used promhttp package, so people who use both have to rename one of the packages.

I certainly don't expect you to rename this package (that would be way too much to ask), but just leaving this as feedback in case you ever do a v2 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant