Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: UMD Bundle #25

Open
amitdahan opened this issue Mar 7, 2018 · 0 comments
Open

Q: UMD Bundle #25

amitdahan opened this issue Mar 7, 2018 · 0 comments

Comments

@amitdahan
Copy link

amitdahan commented Mar 7, 2018

I'm having trouble figuring out why in your UMD config, you set tsconfig.json's module prop to commonjs instead of umd.

In my case, setting it to umd breaks the build, yet commonjs works. Why is this happening?

The only other place I can see a reference to UMD in this setup is in the webpack.umd.config.js file, in the libraryTarget: 'umd' part.

What's going on? In my case at least, this is the only setting combination that "works" but what's going on? Why commonjs in tsconfig.json? Why umd in webpack's libraryTaget? I thought I got everything before but I kinda lost it on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant