Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teuchos: Use of non-existent method #13558

Closed
cgcgcg opened this issue Oct 29, 2024 · 2 comments · Fixed by #13559
Closed

Teuchos: Use of non-existent method #13558

cgcgcg opened this issue Oct 29, 2024 · 2 comments · Fixed by #13559
Labels
pkg: Teuchos Issues primarily dealing with the Teuchos Package type: bug The primary issue is a bug in Trilinos code or tests

Comments

@cgcgcg
Copy link
Contributor

cgcgcg commented Oct 29, 2024

@trilinos/teuchos

Bug Report

Teuchos::ConstNonconstObjectContainer::count uses RCP::count() but there is no such method:

Trilinos/packages/teuchos/core/src/Teuchos_ConstNonconstObjectContainer.hpp

Lines 332 to 333 in e7fd307

int count() const
{ return constObj_.count(); }

What's the correct fix here?

  • Use RCP::weak_count(), or
  • use RCP::strong_count(), or
  • delete Teuchos::ConstNonconstObjectContainer::count since it's not used anywhere?
@cgcgcg cgcgcg added pkg: Teuchos Issues primarily dealing with the Teuchos Package type: bug The primary issue is a bug in Trilinos code or tests labels Oct 29, 2024
@bartlettroscoe
Copy link
Member

bartlettroscoe commented Oct 30, 2024 •
edited
Loading

I would vote for deleting it. Users can just grab the RCP and query the count themselves.

@cgcgcg
Copy link
Contributor Author

cgcgcg commented Oct 30, 2024

@bartlettroscoe Sounds good. I'll delete the method.

@cgcgcg cgcgcg mentioned this issue Oct 30, 2024
Merged
@cgcgcg cgcgcg linked a pull request Oct 30, 2024 that will close this issue
Teuchos: Delete ConstNonconstObjectContainer::count method #13559
Merged
@cgcgcg cgcgcg closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg: Teuchos Issues primarily dealing with the Teuchos Package type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Teuchos: Delete ConstNonconstObjectContainer::count method cgcgcg/Trilinos
2 participants
@bartlettroscoe @cgcgcg