From 142880294fbc9ccb2d79bf3e1874732bf9723f10 Mon Sep 17 00:00:00 2001 From: Benjamin Braun Date: Thu, 6 Feb 2025 03:35:00 +0000 Subject: [PATCH] Fix build-secret flag not being set breaking build.py by changing secrets checks to accurately evaluate the state of the dictionary. --- build.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build.py b/build.py index 1a3c1c9750..841a7da471 100755 --- a/build.py +++ b/build.py @@ -1868,7 +1868,7 @@ def create_docker_build_script(script_name, container_install_dir, container_ci_ "docker", "build", ] - if secrets != "": + if secrets: finalargs += [ f"--secret id=req,src={requirements}", f"--build-arg VLLM_INDEX_URL={vllm_index_url}", @@ -2861,7 +2861,7 @@ def enable_all(): backends["python"] = backends["vllm"] secrets = dict(getattr(FLAGS, "build_secret", [])) - if secrets is not None: + if secrets: requirements = secrets.get("req", "") vllm_index_url = secrets.get("vllm_index_url", "") pytorch_triton_url = secrets.get("pytorch_triton_url", "")