Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fishroom web interface cannot auto scrolling when new message comes #58

Open
Yanhao opened this issue Jan 17, 2017 · 7 comments
Open

fishroom web interface cannot auto scrolling when new message comes #58

Yanhao opened this issue Jan 17, 2017 · 7 comments

Comments

@Yanhao
Copy link

Yanhao commented Jan 17, 2017

It makes me see the new message only if I scroll down page manually.

@huiyiqun
Copy link
Member

It's very silly to auto scroll down page when new message comes especially if you are exploring histories.

I guess we should scroll down only when we are at the button of histories.

@Yanhao
Copy link
Author

Yanhao commented Jan 17, 2017

agreed, but that's not what it is now right?

@bigeagle
Copy link
Member

Indeed, fishroom is designed as @huiyiqun describes.
https://github.com/tuna/fishroom/blob/master/fishroom/web/chat_log.html#L150

@huiyiqun
Copy link
Member

Actually, It does not work on Chrome 55.

What's more, sending message should also scroll the history.

@Yanhao
Copy link
Author

Yanhao commented Jan 17, 2017

@bigeagle I got little confused, seems that it doesn't work that way on my chrome and firefox browser.
Here is the version:
chrome: 54.0.2840.100 (64-bit)
firefox: 45.6.0 (64-bit)

@bigeagle
Copy link
Member

This piece of code is written 1 year ago. Many things can happen within 1 year. 😢

@Yanhao
Copy link
Author

Yanhao commented Jan 17, 2017

@bigeagle sad = =

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants