You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From what I saw, ostruct was added to the gemspec because it was needed by a rubocop fromatter as part of the test-and-deploy.yml GitHub CI workflow, which failed on a deprecation warning becaue ostruct will removed from the Ruby std lib in v3.5.0 and therefore has to be installed explicitly.
Adding these dependencies to Twilio's gemspec does "solve" the problem by making the gems available, but it also indicates that they are required fo Twilio to function, which I don't think is true; I didn't see any references to OpenStruct in the Twilio source, and the gem was ultimately loaded by rubocop as part of a CI step (where rubcop is actually added to the bundle individually, here); thus, ostruct seems to be required by the Twilio CI workflow but not by Twilio itself. (And I assume the same is true for benchmark.)
These gems should be removed from the gemspec in order to avoid the confusion that they are required for Twilio and also prevent future users of this gem from having to install those dependences.
The text was updated successfully, but these errors were encountered:
Introduced in v7.4.2 by #738 and #739.
From what I saw, ostruct was added to the gemspec because it was needed by a rubocop fromatter as part of the test-and-deploy.yml GitHub CI workflow, which failed on a deprecation warning becaue ostruct will removed from the Ruby std lib in v3.5.0 and therefore has to be installed explicitly.
Adding these dependencies to Twilio's gemspec does "solve" the problem by making the gems available, but it also indicates that they are required fo Twilio to function, which I don't think is true; I didn't see any references to OpenStruct in the Twilio source, and the gem was ultimately loaded by rubocop as part of a CI step (where rubcop is actually added to the bundle individually, here); thus, ostruct seems to be required by the Twilio CI workflow but not by Twilio itself. (And I assume the same is true for benchmark.)
These gems should be removed from the gemspec in order to avoid the confusion that they are required for Twilio and also prevent future users of this gem from having to install those dependences.
The text was updated successfully, but these errors were encountered: