Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ostruct and benchmark should not be production Twilio dependencies #743

Open
oehlschl opened this issue Feb 7, 2025 · 1 comment · May be fixed by #742
Open

ostruct and benchmark should not be production Twilio dependencies #743

oehlschl opened this issue Feb 7, 2025 · 1 comment · May be fixed by #742

Comments

@oehlschl
Copy link

oehlschl commented Feb 7, 2025

Introduced in v7.4.2 by #738 and #739.

From what I saw, ostruct was added to the gemspec because it was needed by a rubocop fromatter as part of the test-and-deploy.yml GitHub CI workflow, which failed on a deprecation warning becaue ostruct will removed from the Ruby std lib in v3.5.0 and therefore has to be installed explicitly.

Adding these dependencies to Twilio's gemspec does "solve" the problem by making the gems available, but it also indicates that they are required fo Twilio to function, which I don't think is true; I didn't see any references to OpenStruct in the Twilio source, and the gem was ultimately loaded by rubocop as part of a CI step (where rubcop is actually added to the bundle individually, here); thus, ostruct seems to be required by the Twilio CI workflow but not by Twilio itself. (And I assume the same is true for benchmark.)

These gems should be removed from the gemspec in order to avoid the confusion that they are required for Twilio and also prevent future users of this gem from having to install those dependences.

@oehlschl
Copy link
Author

oehlschl commented Feb 7, 2025

I believe this understanding is accurate, but please feel free to correct if not.

@oehlschl oehlschl linked a pull request Feb 7, 2025 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant