Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conditional requests #13

Open
twodayslate opened this issue Jun 18, 2020 · 1 comment
Open

Use conditional requests #13

twodayslate opened this issue Jun 18, 2020 · 1 comment

Comments

@twodayslate
Copy link
Owner

twodayslate commented Jun 18, 2020

When communicating with the GitHub team they recommended using conditional requests when parsing packages. This would help with any API rate limiting issues.

Currently whenever a package is viewed that is an API request.

req.octokitWithPersonalAccessToken.repos.get({ owner: req.params.owner, repo: req.params.repo }).then(async function (repository) {

Instead it should be a database lookup, if the conditional request does not say there is an update.

@twodayslate
Copy link
Owner Author

twodayslate commented Apr 15, 2021

If there is an update should parse the new package. tightly coupled with #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant