Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag fallback for releases #5

Open
twodayslate opened this issue Mar 25, 2020 · 3 comments
Open

tag fallback for releases #5

twodayslate opened this issue Mar 25, 2020 · 3 comments

Comments

@twodayslate
Copy link
Owner

twodayslate commented Mar 25, 2020

Some projects do not have releases and just use tags

Example: https://github.com/svdo/swift-netutils/releases

The api call for releases is empty

Also need to make sure the greatest semver # is taken from the releases and tags

@twodayslate
Copy link
Owner Author

twodayslate commented Mar 31, 2020

I may have to relook at this. Look at tags and hope the tag is a semver? What is the official way they do this? https://github.com/apple/swift-package-manager

Seems like it... https://github.com/apple/swift-package-manager/blob/1444b46dbc13477f027959e4d59e520747fc8382/swift-tools-support-core/Sources/TSCUtility/Git.swift#L14

@twodayslate
Copy link
Owner Author

@igor-makarov the GitHub API exposes the tags with /tags. Currently only /releases is checked.

Once the latest tag is found (or default branch) I simply fetch the tarball

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants