-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem downloading media from the base station due to the new year. #114
Comments
I finally decided to tackle this issue myself and discovered that in the media.py file at line 350 the _fetch_library routine converts the date_from and date_to into integers and then loops between them. This is what is causing the bad URL's containing the invalid dates. The worst case is when January 1st occurs, but I found this also happens at the first of every month. For example, on January 31st the dates go like this: 20240131 This causes several dozens of bad requests per camera between months and several thousands of bad requests between years. So, I changed the for loop at line 350 from this: To this:
This fixed the issue for me. |
Thanks for doing this. Want to create a PR for it?
…On Tue, Feb 18, 2025, 12:41 Jeffrey Randall ***@***.***> wrote:
I finally decided to tackle this issue myself and discovered that in the
media.py file at line 350 the _fetch_library routine converts the date_from
and date_to into integers and then loops between them. This is what is
causing the bad URL's containing the invalid dates. The worst case is when
January 1st occurs, but I found this also happens at the first of every
month. For example, on January 31st the dates go like this:
20240131
20240132
20240133
.
. and so on
.
20240199
20240200
20240201
This causes several dozens of bad requests per camera between months and
several thousands of bad requests between years.
So, I changed the for loop at line 350 from this:
for date in range(int(date_from), int(date_to) + 1):
To this:
days = self._arlo.cfg.library_days
for i in range(0, days + 1):
date = (datetime.strptime(date_to, "%Y%m%d") - timedelta(days=days - i)).strftime("%Y%m%d")
This fixed the issue for me.
—
Reply to this email directly, view it on GitHub
<#114 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALHJU6VTDTGMVHOZ73C7VVT2QNWC3AVCNFSM6AAAAABXMHI7X2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRWGQZDGMBSGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
[image: Jeff-Rand]*Jeff-Rand* left a comment (twrecked/pyaarlo#114)
<#114 (comment)>
I finally decided to tackle this issue myself and discovered that in the
media.py file at line 350 the _fetch_library routine converts the date_from
and date_to into integers and then loops between them. This is what is
causing the bad URL's containing the invalid dates. The worst case is when
January 1st occurs, but I found this also happens at the first of every
month. For example, on January 31st the dates go like this:
20240131
20240132
20240133
.
. and so on
.
20240199
20240200
20240201
This causes several dozens of bad requests per camera between months and
several thousands of bad requests between years.
So, I changed the for loop at line 350 from this:
for date in range(int(date_from), int(date_to) + 1):
To this:
days = self._arlo.cfg.library_days
for i in range(0, days + 1):
date = (datetime.strptime(date_to, "%Y%m%d") - timedelta(days=days - i)).strftime("%Y%m%d")
This fixed the issue for me.
—
Reply to this email directly, view it on GitHub
<#114 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALHJU6VTDTGMVHOZ73C7VVT2QNWC3AVCNFSM6AAAAABXMHI7X2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRWGQZDGMBSGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Welp... I will give it a shot. I've never done a pull request before. So, please excuse my lack of knowledge. |
I created the PR #180 |
This morning my program stopped downloading videos from my base station. I noticed error messages with odd dates in the URL. I use library_days=1 when I open pyaarlo.PyArlo. Ordinarily, this would generate six requests. One for the current date and one for the previous day for each of the three cameras I have. Now I'm seeing dozens of requests with odd dates (see the list below). It appears that there is an issue with the calculation of dates when crossing into the new year. I am able to get it to work properly by setting library_days=0, this checks for videos on today's date only (January 1st 2023). If I set library_days greater than zero, it tries to calculate the dates for December 2022 incorrectly.
Here are the URL's with bogus dates:
request=https://192.168.0.30:18721/hmsls/list/20221396/20221396/A2G304K0A17D4 request-error=RemoteDisconnected request=https://192.168.0.30:18721/hmsls/list/20221396/20221396/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221396/20221396/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221397/20221397/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221397/20221397/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221397/20221397/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221398/20221398/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221398/20221398/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221398/20221398/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221399/20221399/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221399/20221399/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221399/20221399/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221400/20221400/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221400/20221400/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221400/20221400/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221401/20221401/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221401/20221401/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221401/20221401/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221402/20221402/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221402/20221402/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221402/20221402/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221403/20221403/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221403/20221403/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221403/20221403/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221404/20221404/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221404/20221404/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221404/20221404/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221405/20221405/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221405/20221405/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221405/20221405/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221406/20221406/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221406/20221406/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221406/20221406/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221407/20221407/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221407/20221407/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221407/20221407/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221408/20221408/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221408/20221408/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221408/20221408/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221409/20221409/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221409/20221409/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221409/20221409/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221410/20221410/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221410/20221410/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221410/20221410/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221411/20221411/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221411/20221411/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221411/20221411/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221412/20221412/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221412/20221412/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221412/20221412/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221413/20221413/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221413/20221413/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221413/20221413/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221414/20221414/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221414/20221414/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221414/20221414/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221415/20221415/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221415/20221415/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221415/20221415/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221416/20221416/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221416/20221416/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221416/20221416/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221417/20221417/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221417/20221417/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221417/20221417/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221418/20221418/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221418/20221418/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221418/20221418/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221419/20221419/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221419/20221419/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221419/20221419/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221420/20221420/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221420/20221420/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221420/20221420/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221421/20221421/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221421/20221421/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221421/20221421/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221422/20221422/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221422/20221422/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221422/20221422/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221423/20221423/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221423/20221423/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221423/20221423/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221424/20221424/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221424/20221424/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221424/20221424/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221425/20221425/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221425/20221425/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221425/20221425/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221426/20221426/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221426/20221426/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221426/20221426/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221427/20221427/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221427/20221427/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221427/20221427/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221428/20221428/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221428/20221428/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221428/20221428/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221429/20221429/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221429/20221429/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221429/20221429/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221430/20221430/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221430/20221430/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221430/20221430/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221431/20221431/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221431/20221431/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221431/20221431/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221432/20221432/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221432/20221432/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221432/20221432/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221433/20221433/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221433/20221433/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221433/20221433/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221434/20221434/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221434/20221434/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221434/20221434/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221435/20221435/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221435/20221435/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221435/20221435/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221436/20221436/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221436/20221436/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221436/20221436/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221437/20221437/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221437/20221437/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221437/20221437/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221438/20221438/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221438/20221438/A431087AA236E request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221438/20221438/A431087DA2A16 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221439/20221439/A2G304K0A17D4 request-error=URLError request=https://192.168.0.30:18721/hmsls/list/20221439/20221439/A431087AA236E request-error=URLError
The text was updated successfully, but these errors were encountered: