Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pyaarlo-0.8.0.17] Python 3.7 is no longer the minimum python version #178

Open
chief-swole opened this issue Feb 18, 2025 · 3 comments
Open

Comments

@chief-swole
Copy link

In the setup.py, the minimum python version is declared to be 3.7:

    python_requires='>=3.7',

however, when run on Python 3.7, I get this error:

  File "/Users/me/.virtualenvs/arlo_downloader/lib/python3.8/site-packages/pyaarlo/backend.py", line 65, in ArloBackEnd
    _user_id: str | None = None
TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'
@chief-swole chief-swole changed the title Python 3.7 is no longer the minimum python version [pyaarlo-0.8.0.17] Python 3.7 is no longer the minimum python version Feb 18, 2025
@chief-swole
Copy link
Author

chief-swole commented Feb 18, 2025

fastapi/typer#371 (comment)

| was added in python 3.10, so not available in python 3.8.

def test(flag: bool | None = typer.Option(None, "--flag", "-f", help="A flag")):
Either you can use typing.Union or you can use string for type annotation, like:

def test(flag: "bool | None" = typer.Option(None, "--flag", "-f", help="A flag")):

Can we use typing.Union instead? 3.10 is a huge jump as a min version. I fear what other dependency issues I'll hit jumping to 3.10.

@twrecked
Copy link
Owner

twrecked commented Feb 18, 2025 via email

@twrecked
Copy link
Owner

Can you try the master branch? I just pushed a possible fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants