[Edge] - Some weird apps installed

[taiebot]

• Device: mako
• Channel: Edge
• Build: 2019-02-27

Steps to reproduce

Open the app launcher

Expected behavior

All the apps i own are shown

Actual behavior

Htop icon is displayed (not installed in libertine) => clicking on it tries to launch something but nothing is shown...
Sync Mon is displayed with no icon =>clicking on it tries to launch something but nothing is shown...

[kugiigi]

I think these apps are installed even in the other channels however the app drawer seems to get all desktop file regardless if it has "X-Ubuntu-Touch=true" or not unlike the apps scope.

[dobey]

It should only be showing the same results you would see if you run ubuntu-app-launch-appids as it's getting the listing the same way.

[NeoTheThird]

Thinking of where we want to go with convergence in the long run, i don't think it would be a good idea to limit ourselves to apps with X-Ubuntu-Touch in the long run. If we do that, non-click apps can never become first-class citizens.

For now, i'd suggest to remove htop for the reasons i detailed here. I didn't look into sync monitor yet. There's probably a desktop file we can remove.

[dobey]

The listing isn't limited to apps with X-Ubuntu-Touch though, @NeoTheThird.

[dobey]

Also, I'm not sure why htop would be installed by default? We should probably remove that. And why does sync-monitor have a .desktop file? It has an empty Exec= and seems to serve no purpose. It should probably be removed from the install there.

[NeoTheThird]

The listing isn't limited to apps with X-Ubuntu-Touch though, @NeoTheThird.

My point. But it was until ota-8. With the drawer it's not, so those new "weird apps" are displayed. I think it's good to show all apps, regarding where we want to go with convergence.

Also, I'm not sure why htop would be installed by default? We should probably remove that.

See ubports/ubuntu-touch-meta#40

And why does sync-monitor have a .desktop file? It has an empty Exec= and seems to serve no purpose. It should probably be removed from the install there.

Because of the weird things we do with the desktop file hints. It does serve a purpose. Hiding it like i did in ubports/sync-monitor#10 is enough, imho.