-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qset standardization, preflight checks + various smaller patches #124
base: dev/3.0.3
Are you sure you want to change the base?
Conversation
…dancy and enable the 'Download Package' button on the splash screen, started working out backend logic for making preflight checks.
…o the output from the preflight checklist. Covered all checks so far.
- Qset will now be forced to conform to the same structure that Materia Docker enforces it to be
…ue/43 # Conflicts: # assets/css/mwdk-download.css # express.js # views/download.html # views/index.html
# Conflicts: # .gitignore # express.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great aside from a few missing references that were hard-coded to the layout handlebar file. One other thing I've noticed: the score screen is an optional addition to the install.yaml
, and the preflight check should indicate that.
If the score screen property is present in install.yaml
, we should probably verify the file referenced actually exists. Potentially conversely, if a score screen html file is present, it should probably check that the property is in the install.yaml
.
It looks like most of these issues come from work Brandon did 5 years ago when he initially did the pre-flight check system (looks like all from the first commit on this PR). I'll go through and remove em' since they don't seem applicable anymore, as well as add the score screen checks. |
- Removed old dependencies that were a part of a commit 5 years ago - Changed scoreScreen preflight checks to pass if the property is not present - Additionally will now fail is a custom scoreScreen file is present but the property is not specified in the install.yaml
This PR is built off of dev/3.0.3 and requires that to be merged in first
This PR includes a many fixes and patches for various things:
install.yaml
(files.player, files.creator, score.score_screen). Appropriately,webpack.config.js
must be configured to output widget files using those same names.install.yaml
is validated as part of the preflight checks above.webpack.config.js
orwebpack.config.cjs
when initializing. This allows the easy use of an explicitly-defined CommonJS webpack config, saving some headaches when your project is using"type": "module"
(like Pyramid Game is)The only thing not addressed in the original issue is #21, or any of the 'qset editor' or 'install.yaml editor's mentioned in any of the other issues