Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Missing Modules should import rather than append to prioritize local module #675

Open
jonespm opened this issue Dec 9, 2024 · 0 comments · May be fixed by #680
Open

Find Missing Modules should import rather than append to prioritize local module #675

jonespm opened this issue Dec 9, 2024 · 0 comments · May be fixed by #680
Labels

Comments

@jonespm
Copy link
Contributor

jonespm commented Dec 9, 2024

Describe the bug

When running the test find_missing_modules.py, it will fail if a new module is added locally while an older version of CanvasAPI is installed in the path that doesn't have this. This is because the local path has the lower priority. I don't think this will be a problem with Github action

To Reproduce

Steps to reproduce the behavior:

  • Install a version of CanvasAPI globally or in the virtual environment
  • Add a new module, also import it in another module as required.
  • Attempt to run the scripts/find_missing_modules.py

Script should pass if done correctly. It fails. If the global canvasapi is removed this test does pass.

Expected behavior

The local canvasapi should always be preferred by this test

sys.path.insert(0, os.path.join(os.path.dirname(__file__), ".."))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant