[NODRIVER] NameError: name 'items' is not defined in async select method

[khamaileon]

Description:
When using the select method, a NameError is raised:

NameError: name 'items' is not defined. Did you mean: 'item'?

  async def select(
      self,
      selector: str,
      timeout: Union[int, float] = 10,
  ) -> nodriver.Element:
      """
      find single element by css selector.
      can also be used to wait for such element to appear.

      :param selector: css selector, eg a[href], button[class*=close], a > img[src]
      :type selector: str

      :param timeout: raise timeout exception when after this many seconds nothing is found.
      :type timeout: float,int

      """
      loop = asyncio.get_running_loop()
      start_time = loop.time()

      selector = selector.strip()
      item = await self.query_selector(selector)

      while not item:
          await self
          item = await self.query_selector(selector)
          if loop.time() - start_time > timeout:
              return items
          await self.sleep(0.5)
      return item

Steps to Reproduce:

1. Call the select method with a CSS selector and a timeout value.
2. Ensure that no matching element appears within the timeout period.
3. Observe the NameError when the return items line is executed.

Expected Behavior:
The method should raise an appropriate exception if no matching element is found within the timeout period.

Actual Behavior:
The method raises a NameError because the variable items is not defined.

[stephanlensky]

Hey @khamaileon, I created a fork of nodriver here stephanlensky/zendriver which fixes this and other bugs, feel free to take a look.

[khamaileon]

I can confirm that the problem is resolved with Zendriver.