Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15 - Outdated typescript import in Custom Property Editor example - UmbPropertyEditorUiElement #6797

Open
nackler opened this issue Jan 14, 2025 · 3 comments

Comments

@nackler
Copy link

nackler commented Jan 14, 2025

What type of issue is it?

Wrong documentation

What article/section is this about?

https://docs.umbraco.com/umbraco-cms/tutorials/creating-a-property-editor

Describe the issue

In the 'custom property editor' instructions, in the 'Creating a Web Component' section, there is an example .ts file with an incorrect import.
The example shows
import { UmbPropertyEditorUiElement } from "@umbraco-cms/backoffice/extension-registry";

I couldn't get that to build in v15 until I changed it to
import type { UmbPropertyEditorUiElement } from '@umbraco-cms/backoffice/property-editor';

@sofietoft
Copy link
Contributor

Thanks for the report @nackler ! 💪

Would you be up for making a PR with the change yourself?
We have some docs on how to contribute here: https://docs.umbraco.com/contributing/documentation/getting-started/pull-request

Let me know if you're up for it, or I'll add a task for the docs team here at Umbraco HQ! 😄

@nackler
Copy link
Author

nackler commented Jan 15, 2025

Thanks for the offer @sofietoft but I'm out of my depth when it comes to typescript so I'd be more comfortable if someone else corroborated my suggestion and made the change.

@sofietoft
Copy link
Contributor

No worries @nackler ! 💪

I'll make sure a task for it is added to the team here at Umbraco HQ!
Thanks again for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants