From 52f8be08f12a3866137e681737de9a86c7957861 Mon Sep 17 00:00:00 2001
From: Undyingwraith <Undyingwraith@outlook.com>
Date: Fri, 31 Jan 2025 09:50:58 +0100
Subject: [PATCH] Reduce amount of renders

---
 .../ui/src/components/atoms/TimeDisplay.tsx     | 15 ++++++++-------
 packages/ui/src/components/atoms/index.ts       |  2 ++
 .../organisms/VideoPlayer/VideoPlayer.tsx       | 17 ++++++-----------
 3 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/packages/ui/src/components/atoms/TimeDisplay.tsx b/packages/ui/src/components/atoms/TimeDisplay.tsx
index 0108c04..625ccdf 100644
--- a/packages/ui/src/components/atoms/TimeDisplay.tsx
+++ b/packages/ui/src/components/atoms/TimeDisplay.tsx
@@ -1,20 +1,21 @@
+import { Signal, useComputed } from '@preact/signals-react';
 import React from 'react';
 
-export function TimeDisplay(props: { time: number; }) {
+export function TimeDisplay(props: { time: Signal<number>; }) {
 	const { time } = props;
 
 	function pad(num: number) {
-		const test = '00' + num;
-		return (test).substring(test.length - 2);
+		const str = '00' + num;
+		return (str).substring(str.length - 2);
 	}
 
-	const hours = Math.floor(time / 3600);
-	const minutes = Math.floor(time % 3600 / 60);
-	const seconds = Math.floor(time % 3600 % 60);
+	const hours = useComputed(() => pad(Math.floor(time.value / 3600)));
+	const minutes = useComputed(() => pad(Math.floor(time.value % 3600 / 60)));
+	const seconds = useComputed(() => pad(Math.floor(time.value % 3600 % 60)));
 
 	return (
 		<div>
-			{`${pad(hours)}:${pad(minutes)}:${pad(seconds)}`}
+			{hours}:{minutes}:{seconds}
 		</div>
 	);
 }
diff --git a/packages/ui/src/components/atoms/index.ts b/packages/ui/src/components/atoms/index.ts
index fbcbe99..9e2b777 100644
--- a/packages/ui/src/components/atoms/index.ts
+++ b/packages/ui/src/components/atoms/index.ts
@@ -1,4 +1,5 @@
 export { ErrorBoundary } from './ErrorBoundary';
+export { FileInfoDisplay } from './FileInfoDisplay';
 export { FileInput } from './FileInput';
 export { FormList } from './FormList';
 export { Identicon } from './Identicon';
@@ -8,3 +9,4 @@ export { SelectInput } from './SelectInput';
 export { Spacer } from './Spacer';
 export { TextInput } from './TextInput';
 export { ThemeToggle } from './ThemeToggle';
+export { TimeDisplay } from './TimeDisplay';
diff --git a/packages/ui/src/components/organisms/VideoPlayer/VideoPlayer.tsx b/packages/ui/src/components/organisms/VideoPlayer/VideoPlayer.tsx
index 77e479f..80ca6de 100644
--- a/packages/ui/src/components/organisms/VideoPlayer/VideoPlayer.tsx
+++ b/packages/ui/src/components/organisms/VideoPlayer/VideoPlayer.tsx
@@ -7,9 +7,8 @@ import React from 'react';
 import shaka from 'shaka-player';
 import { useService } from '../../../context';
 import { useHotkey } from '../../../hooks';
-import { FileInfoDisplay } from '../../atoms/FileInfoDisplay';
+import { FileInfoDisplay, TimeDisplay } from '../../atoms';
 import styles from './VideoPlayer.module.css';
-import { TimeDisplay } from '../../atoms/TimeDisplay';
 
 function createShakaIpfsPlugin(ipfs: IIpfsService): shaka.extern.SchemePlugin {
 	return async (uri: string, request: shaka.extern.Request, requestType: shaka.net.NetworkingEngine.RequestType, progressUpdated: shaka.extern.ProgressUpdated, headersReceived: shaka.extern.HeadersReceived, config: shaka.extern.SchemePluginConfig) => {
@@ -168,20 +167,16 @@ export function VideoPlayer(props: { file: IVideoFile; autoPlay?: boolean; }) {
 	useHotkey({ key: 'F' }, () => toggleFullScreen());
 	useHotkey({ key: 'Space' }, () => togglePlay());
 
-	const progressBar = useComputed(() => (
-		<div className={styles.progress} ref={(ref) => progressRef.value = ref}>
-			<div className={styles.progressFilled} ref={(ref) => progressBarRef.value = ref} />
-		</div>
-	));
-
 	const progress = useComputed(() => (
 		<div className={styles.progressContainer}>
 			<TimeDisplay
-				time={currentPlayTime.value}
+				time={currentPlayTime}
 			/>
-			{progressBar}
+			<div className={styles.progress} ref={(ref) => progressRef.value = ref}>
+				<div className={styles.progressFilled} ref={(ref) => progressBarRef.value = ref} />
+			</div>
 			<TimeDisplay
-				time={movieDuration.value}
+				time={movieDuration}
 			/>
 		</div>
 	));