Input event `Timestamp` should be in microseconds #19147

MartinZikmund · 2025-01-03T14:39:46Z

GitHub Issue (If applicable): closes #14535

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

unodevops · 2025-01-03T15:13:17Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html

unodevops · 2025-01-03T15:21:52Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19147/index.html

src/Uno.UI.Runtime.Skia.MacOS/MacOSWindowHost.cs

unodevops · 2025-01-07T12:59:59Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html

unodevops · 2025-01-07T13:01:10Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19147/index.html

unodevops · 2025-01-07T15:19:46Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html

unodevops · 2025-01-07T17:00:06Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html

unodevops · 2025-01-07T17:53:41Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19147/index.html

unodevops · 2025-01-08T11:43:01Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html

unodevops · 2025-01-08T12:48:34Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19147/index.html

dr1rrb

Thank you so much to have renamed all variables to reflect the new unit 🙏

src/Uno.UI.Runtime.Skia.X11/X11PointerInputSource.XInput.cs

src/Uno.UI/UI/Input/PointerPoint.cs

dr1rrb · 2025-01-08T14:39:47Z

src/Uno.UI/UI/Xaml/Input/PointerRoutedEventArgs.iOS.cs

-			_bootTime ??= DateTime.UtcNow.Ticks - (long)(TimeSpan.TicksPerSecond * new NSProcessInfo().SystemUptime);
-
-			return (ulong)_bootTime.Value + (ulong)(TimeSpan.TicksPerSecond * timestamp);
+			// iOS Timestamp is in seconds from boot time.


This was to patch something like the timestamp being "paused" when the app was not in foreground (if I've good memory). Did you look in the history why it has been added and confirmed that it's no longer needed?

@dr1rrb Based on the history it is not too clear why it got introduced 🤔 . However I don't yet understand how it works -

On the first call to ToTimeStamp the _bootTime is initialized to (current time) - (systemuptime) = the datetime when the device was booted up represented as ticks.

On subsequent time it calculates (boot time ticks) + timestamp = the datetime of the event represented as ticks. However, the output value should be just time span since boot time, not the datetime represented as ticks. Also, if the timestamp is the thing that gets paused when app is going in background, it will still result in the same value, as boot time remains constant from the first assignment

Finally I found that NSProcessInfo.SLystemUptime is potentially problematic 👀 - https://developer.apple.com/documentation/foundation/nsprocessinfo/1414553-systemuptime#discussion

unodevops · 2025-01-08T15:00:22Z

⚠️⚠️ The build 151305 has failed on Uno.UI - CI.

unodevops · 2025-01-08T15:47:54Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html

src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOApplication.m

unodevops · 2025-01-08T20:13:39Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19147/index.html

nventive-devops · 2025-01-08T23:53:20Z

The build 151356 found UI Test snapshots differences: android-28-net8: 21, android-28-net8-Snap: 39, ios: 7, ios-Snap: 43, skia-gtk-screenshots: 57, skia-linux-screenshots: 62, skia-windows-screenshots: 60, wasm: 485, wasm-automated-net9.0-UWP-Default-automated: 29, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 21 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- Flyout_ShowAt_Window_Content_UITests_Windows_UI_Xaml_Controls_FlyoutTests_Flyout_ShowAt_Window_Content
- MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- NavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
- When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- FlyoutTest_When_OverlayInputPassThroughElement_Then_PassThrough_withOff_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- WebView_NavigateToAnchor_Initial
android-28-net8-Snap: 39 changed over 1067
🚨🚨 Comparison Details (first 20) 🚨🚨
- Border_Border_AntiAlias_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderAntiAlias
- Icons_UITests_Windows_UI_Xaml_Controls_SymbolIconTests_SymbolIcon_Generic_UITests_Windows_UI_Xaml_Controls_SymbolIconTests_SymbolIcon_Generic
- ListView_ListViewSnapPointsMandatorySingle_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSnapPointsMandatorySingle
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
- ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample
- Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage
- RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
- ListView_ListView_FirstLastCacheIndex_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_FirstLastCacheIndex
- GridView_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Border_Border_Corner_Overlap_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerOverlap
- MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- ListView_ListViewMarginTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewMarginTest
- ListView_ListViewResizableText_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListViewResizableText
ios: 7 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
- Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
ios-Snap: 43 changed over 1058
🚨🚨 Comparison Details (first 20) 🚨🚨
- Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
- Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
- Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Shapes_LinePage_SamplesApp_Windows_UI_Xaml_Shapes_LinePage
- Buttons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
- ListView_ListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGrouped
- ListView_ListView_TextBox_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_TextBox
- NavigationView_MUXControlsTestApp_NavigationViewMenuItemStretchPage_MUXControlsTestApp_NavigationViewMenuItemStretchPage
- NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
- ContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Uno_UI_Samples_UITests_Image_Image_Stretch
- NavigationView_NavigationViewSample_SamplesApp_Samples_NavigationViewSample_NavigationViewSample
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
skia-gtk-screenshots: 57 changed over 2232
🚨🚨 Comparison Details (first 20) 🚨🚨
- Rectangle.png-dark
- Rectangle.png
- ExpanderColorValidationPage.png
- UIElement_Layout_Bug2879.png-dark
- UIElement_Layout_Bug2879.png
- ListViewHeaderUpdate.png-dark
- ListViewHeaderUpdate.png
- ExpanderColorValidationPage.png-dark
- NetworkInformation.png-dark
- NetworkInformation.png
- PasswordBox_AutoFill.png-dark
- PasswordBox_AutoFill.png
- Popup_Simple.png-dark
- Popup_Simple.png
- ClipboardTests.png-dark
- ClipboardTests.png
- DoubleImageBrushInList.png-dark
- DoubleImageBrushInList.png
- DropDownButtonPage.png
- DisplayInformation.png-dark
skia-linux-screenshots: 62 changed over 2232
🚨🚨 Comparison Details (first 20) 🚨🚨
- Buttons.png
- DisplayInformation.png-dark
- DisplayInformation.png
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- CompositionEffectBrush.png-dark
- CompositionEffectBrush.png
- ImageIconPage.png-dark
- ImageIconPage.png
- BorderImageBrushRelativeTransform.png-dark
- BorderImageBrushRelativeTransform.png
- Focus_FocusVisual_Properties.png-dark
- Focus_FocusVisual_Properties.png
- BorderImageBrush.png-dark
- CalendarView_Theming.png-dark
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- ImageBrushStretch.png-dark
- ImageBrushStretch.png
- BorderImageBrush.png
skia-windows-screenshots: 60 changed over 2232
🚨🚨 Comparison Details (first 20) 🚨🚨
- AppWindowPositionAndSize.png-dark
- ButtonClippingTestsControl.png-dark
- ButtonClippingTestsControl.png
- Buttons.png-dark
- ClipboardTests.png-dark
- CalendarView_Theming.png-dark
- ColorPickerSample.png-dark
- DisplayInformation.png-dark
- DisplayInformation.png
- BorderImageBrushRelativeTransform.png-dark
- Focus_FocusVisual_Properties.png-dark
- Focus_FocusVisual_Properties.png
- AppWindowPositionAndSize.png
- ImageBrushInList.png-dark
- ImageBrushInList.png
- ColorPickerSample.png
- BorderImageBrushRelativeTransform.png
- Examples.png
- Buttons.png
- DropDownButtonPage.png-dark
wasm: 485 changed over 1043
🚨🚨 Comparison Details (first 20) 🚨🚨
- GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionMode
- MUXControlsTestApp.RadialGradientBrushPage
- SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2ControlJavaScriptAlertConfirmPrompt
- SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_AnchorNavigation
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Popover
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ItemsSource
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ScrollViewer
- SamplesApp.Windows_UI_Xaml.Clipping.Transform_Ellipse_In_Canvas_in_Two_Grids
- SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.TransformToVisual_Translate2d
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewChangeView
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGroupedVariableHeightComplexTemplate
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewChangeViewArbitrary
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewResizable
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Inside_ListView
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewScrollIntoViewSnapPoints
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Last_Item_Large
- SamplesApp.Windows_UI_Xaml_Media.Geometry.BezierSegmentPage
- SamplesApp.Windows_UI_Xaml_Media.Geometry.ClosedFigurePage
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchUniformAutoSize
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchUniformHorizontalAlignmentCenter
wasm-automated-net9.0-UWP-Default-automated: 29 changed over 1947
🚨🚨 Comparison Details (first 20) 🚨🚨
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- Default_StrokeThickness_MyEllipse_0_StrokeThickness
- Default_StrokeThickness_MyLine
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- Default_StrokeThickness_MyPolygon_0_StrokeThickness
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Default_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Border_OnepxThicknessandRadiusAndTextBlock_Uno_UI_Samples_UITests_BorderTestsControl_OnepxThicknessandRadiusAndTextBlock
- Default_StrokeThickness_MyPath
- Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
- Default_StrokeThickness_MyRect
- Default_StrokeThickness_MyRect_0_StrokeThickness
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

unodevops · 2025-01-09T02:50:20Z

⚠️⚠️ The build 151356 has failed on Uno.UI - CI.

MartinZikmund added 5 commits January 3, 2025 14:47

chore: Add centralized timestamp retrieval

143affd

fix: Adjust Skia desktop PointerPoint.Timestamp to microseconds

2d9d354

fix: Adjust WASM PointerPoint.Timestamp to microseconds

d743eb6

fix: Adjust Android PointerPoint.Timestamp to microseconds

47b4ed1

fix: Adjust iOS PointerPoint.Timestamp to microseconds

92d524b

fix: Adjust Timestamp usages to refer to microseconds

d381d61

MartinZikmund force-pushed the dev/mazi/timestamp-pointerpoint branch from d89af73 to d381d61 Compare January 3, 2025 14:40

spouliot reviewed Jan 3, 2025

View reviewed changes

src/Uno.UI.Runtime.Skia.MacOS/MacOSWindowHost.cs Outdated Show resolved Hide resolved

MartinZikmund marked this pull request as draft January 6, 2025 08:14

MartinZikmund requested a review from dr1rrb January 7, 2025 09:32

chore: Adjust const usages

b1da440

github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Jan 7, 2025

chore: Wait for longer between taps in When_IsTextSelectionEnabled_CRLF

31fac4c

MartinZikmund added 2 commits January 7, 2025 16:42

test: Add a manual test for timestamps

c2c4b09

chore: Adjust for better tracking

0ab0b79

MartinZikmund force-pushed the dev/mazi/timestamp-pointerpoint branch from 571c30e to 0ab0b79 Compare January 7, 2025 15:55

chore: Adjust constant

6cd7374

MartinZikmund marked this pull request as ready for review January 8, 2025 11:40

dr1rrb approved these changes Jan 8, 2025

View reviewed changes

fix: Adjust Timestamp to be in microseconds on macOS

b76e708

MartinZikmund force-pushed the dev/mazi/timestamp-pointerpoint branch from 3c6b663 to d211256 Compare January 8, 2025 16:09

chore: Adjust uptime query

ae1a42d

MartinZikmund force-pushed the dev/mazi/timestamp-pointerpoint branch from d211256 to ae1a42d Compare January 8, 2025 16:12

MartinZikmund added 2 commits January 8, 2025 17:40

chore: Simplify further

2bbf1d6

chore: Remove now unused method

adaa4d2

spouliot reviewed Jan 8, 2025

View reviewed changes

src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOApplication.m Outdated Show resolved Hide resolved

MartinZikmund added 3 commits January 9, 2025 12:20

chore: Small refactor

9307c43

chore: Cleanup

d190d43

chore: Remove unused variables

82dece8

MartinZikmund enabled auto-merge January 9, 2025 11:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Input event `Timestamp` should be in microseconds #19147

Input event `Timestamp` should be in microseconds #19147

MartinZikmund commented Jan 3, 2025 •

edited

Loading

unodevops commented Jan 3, 2025

unodevops commented Jan 3, 2025

unodevops commented Jan 7, 2025

unodevops commented Jan 7, 2025

unodevops commented Jan 7, 2025

unodevops commented Jan 7, 2025

unodevops commented Jan 7, 2025

unodevops commented Jan 8, 2025

unodevops commented Jan 8, 2025

dr1rrb left a comment •

edited

Loading

dr1rrb Jan 8, 2025

MartinZikmund Jan 9, 2025 •

edited

Loading

unodevops commented Jan 8, 2025

unodevops commented Jan 8, 2025

unodevops commented Jan 8, 2025

nventive-devops commented Jan 8, 2025

unodevops commented Jan 9, 2025

Input event Timestamp should be in microseconds #19147

Are you sure you want to change the base?

Input event Timestamp should be in microseconds #19147

Conversation

MartinZikmund commented Jan 3, 2025 • edited Loading

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

unodevops commented Jan 3, 2025

unodevops commented Jan 3, 2025

unodevops commented Jan 7, 2025

unodevops commented Jan 7, 2025

unodevops commented Jan 7, 2025

unodevops commented Jan 7, 2025

unodevops commented Jan 7, 2025

unodevops commented Jan 8, 2025

unodevops commented Jan 8, 2025

dr1rrb left a comment • edited Loading

Choose a reason for hiding this comment

dr1rrb Jan 8, 2025

Choose a reason for hiding this comment

MartinZikmund Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

unodevops commented Jan 8, 2025

unodevops commented Jan 8, 2025

unodevops commented Jan 8, 2025

nventive-devops commented Jan 8, 2025

unodevops commented Jan 9, 2025

Input event `Timestamp` should be in microseconds #19147

Input event `Timestamp` should be in microseconds #19147

MartinZikmund commented Jan 3, 2025 •

edited

Loading

dr1rrb left a comment •

edited

Loading

MartinZikmund Jan 9, 2025 •

edited

Loading