Rel has-many pointer type errors out

[reesmanp]

This is using latest Bun on Go 1.17.

I have a has-many relationship on a struct and while trying to select items from it I am receiving this error message *errors.errorString: bun: has-many relation=Items does not have base model=Mission with id=[%!q(*int=0xc0004032a0)] (check join conditions)

The Items struct is defined as:

type Item struct {
    Id                     int          `json:"id" bun:",pk,autoincrement"`
    Name                   string       `json:"name"`
    OwnerId                int          `json:"ownerId"`
    Owner                  User         `json:"owner" bun:"rel:belongs-to,join:owner_id=id"`
    OrganizationId         int          `json:"organizationId"`
    Organization           Organization `json:"organization" bun:"rel:belongs-to,join:organization_id=id"`
    MissionId              *int         `json:"missionId"`
    Mission                *Mission     `json:"mission" bun:"rel:belongs-to,join:mission_id=id"`
}

and the Missions model being:

type Mission struct {
    Id                int           `json:"id" bun:",pk,autoincrement"`
    Name              string        `json:"name"`
    OrganizationId    int           `json:"organizationId"`
    Organization      Organization  `json:"organization" bun:"rel:belongs-to,join:organization_id=id"`
    OwnerId           int           `json:"ownerId"`
    Owner             User          `json:"owner" bun:"rel:belongs-to,join:owner_id=id"`
    VehicleId         int           `json:"vehicleId"`
    Vehicle           Vehicle       `json:"vehicle" bun:"rel:belongs-to,join:vehicle_id=id"`
    Items             []*Item       `json:"items" bun:"rel:has-many,join:id=mission_id"`
}

Items can exist without being assigned to a mission. The query I am trying to run is this:

    missions := new([]models.Mission)
    err := pq.connection.NewSelect().Model(missions).
        Relation("Items").
        Relation("Owner", func(query *bun.SelectQuery) *bun.SelectQuery {
            return query.ExcludeColumn("password").Relation("Owner.Organization")
        }).
        Relation("Organization").
        Relation("Vehicle").
        Relation("Vehicle.Organization").
        Where("mission.organization_id = ?", organizationId).
        Scan(context.Background())

On the Items struct, if I change the pointers to be non-pointers this works. The problem now is that NewInsert does not have an OmitZero method so I have to do this hacky bit:

	var missionId *int
	if item.MissionId > 0 {
		missionId = &item.MissionId
	}
	_, err := pq.connection.NewInsert().Model(item).Value("mission_id", "(?)", missionId).Exec(context.Background())
	return err

Could we get functionality to both include an OmitZero method on NewInsert and allow pointers on rel:belongs-to for rel:has-many relationships?

[vmihailenco]

Perhaps you want to add ,nullzero on some columns instead of using pointers, e.g.

type Item struct {
    Id                     int          `json:"id" bun:",pk,autoincrement"`
    Name                   string       `json:"name"`
    OwnerId                int          `json:"ownerId"`
    Owner                  User         `json:"owner" bun:"rel:belongs-to,join:owner_id=id"`
    OrganizationId         int          `json:"organizationId"`
    Organization           Organization `json:"organization" bun:"rel:belongs-to,join:organization_id=id"`
    MissionId              int         `json:"missionId" bun:",nullzero"`
    Mission                *Mission     `json:"mission" bun:"rel:belongs-to,join:mission_id=id"`
}

and allow pointers on rel:belongs-to for rel:has-many relationships

We should add support for this 👍

include an OmitZero method on NewInsert

Most DBMS support DEFAULT instead of omitting values and we already support that with ,nullzero.

[reesmanp]

The nullzero worked perfectly, thank you

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. If there is no update within the next 7 days, this issue will be closed.