You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In issue #557 there was some initial discussion about adding timeout features to the bruno specification, but what ended up being implemented was only a slice of the discussed functionality (the UI for a system-wide timeout that could be specified in the app preferences). When I started working on integrating Bruno as tests into some CI pipelines, I found some issues though:
There wasn't a way to impact the max runtime of the CLI runner -- so getting into a situation where an HTTP endpoint didn't respond could hang CI jobs forever / until the max runtime from the CI system
I wanted to be able to set timeouts in an order of precedence (like: I want my test suite to have a default of a 10 second max, except this one endpoint which takes a while, which should have a 30 second timeout)
I wanted to be able to set these differently across test suites -- not with a global setting
I wanted a way to have a global setting on the CLI, much like the app-wide setting that's currently implemented
I took a crack at implementing these features & logic below:
I think the most objectionable thing I did was probably renaming the Docs tab to Meta in order to have a grab-bag section of configuration for a couple of settings 🤣 I didn't want to add a whole new tab just for timeouts, so I renamed the tab (and couldn't think of a better name, maybe Misc. would be better) and put the docs + timeout settings under it for now. I think the order of precedence makes sense -- a timeout on an individual request overrides a suite setting if there is one, and suite settings override the app-wide / cli --timeout setting -- but we could discuss if there's concerns there.
Wondering if we could discuss this functionality and try to get some traction behind it, it would be a nice feature addition & help protect our CI systems where we are / want to expand usage of it.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
In issue #557 there was some initial discussion about adding timeout features to the bruno specification, but what ended up being implemented was only a slice of the discussed functionality (the UI for a system-wide timeout that could be specified in the app preferences). When I started working on integrating Bruno as tests into some CI pipelines, I found some issues though:
I took a crack at implementing these features & logic below:
I think the most objectionable thing I did was probably renaming the Docs tab to Meta in order to have a grab-bag section of configuration for a couple of settings 🤣 I didn't want to add a whole new tab just for timeouts, so I renamed the tab (and couldn't think of a better name, maybe Misc. would be better) and put the docs + timeout settings under it for now. I think the order of precedence makes sense -- a timeout on an individual request overrides a suite setting if there is one, and suite settings override the app-wide / cli
--timeout
setting -- but we could discuss if there's concerns there.Wondering if we could discuss this functionality and try to get some traction behind it, it would be a nice feature addition & help protect our CI systems where we are / want to expand usage of it.
Beta Was this translation helpful? Give feedback.
All reactions