From 0105f405b8145f35422a61ab2aaa8d82f69557d9 Mon Sep 17 00:00:00 2001
From: Rob Kirkner <rob@interactiverob.com>
Date: Mon, 7 Oct 2024 13:30:00 -0400
Subject: [PATCH 1/2] Corrects instructions on User hard-delete

The current documentation at https://learn.userfrosting.com/users/user-accounts#delete-accounts references an outdated method for hard-deleting users by passing a $hardDelete parameter

Need advice here - I shared a code example.. but this doesn't work for users that have already been soft-deleted because `null` will be returned when we attempt to `User::find` a soft deleted User.  Is there another method to call User:forceDelete on a user that has already been soft-deleted?



Side note - the https://api.userfrosting.com also should be marked deprecated at this point as it is clearly outdated and has sent me on several wild goose chases for methods that don't exist. Developers will have better luck searching through the source code to get an idea of how to use the internals.
---
 pages/10.users/01.user-accounts/docs.md | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/pages/10.users/01.user-accounts/docs.md b/pages/10.users/01.user-accounts/docs.md
index 639833d0..5279b70e 100644
--- a/pages/10.users/01.user-accounts/docs.md
+++ b/pages/10.users/01.user-accounts/docs.md
@@ -219,5 +219,23 @@ User accounts can be deleted from the user profile page, or the user dropdown me
 
 Deleting user accounts presents a problem because the user may have related data in the database that would become orphaned, potentially breaking other functionality in your site. For this reason, UserFrosting performs [soft deletes](https://laravel.com/docs/8.x/eloquent#soft-deleting) by default. The user record is not actually deleted, but instead a `deleted_at` timestamp is added to the record and the user is no longer able to sign in. Deleted users are also excluded from all queries unless the `withTrashed` method is added to the Eloquent query. Related entities (activities, roles, etc) are left alone.
 
-If you really want to completely remove the user from the database, you can call `User::delete` method in your controller and set
-the `$hardDelete` parameter to `true`. This will detach the user from all of their roles, and delete the user's activity records.
+If you really want to completely remove the user from the database, you can call the `User::forceDelete` method in your controller logic. 
+
+Here's an example using `User::forceDelete` in a custom UserActions class:
+
+```php
+<?php
+use UserFrosting\Sprinkle\Account\Database\Models\User;
+
+class UserActions {
+    public function __construct() {}
+
+    public function delete($userId) {
+        $userModel = new User();
+        $user = $userModel->find($userId);
+
+        if(!$user) return;
+        $user->forceDelete();
+    }
+}
+```

From 8e09ad3375c28c0d9908132c3dea586e86dd0f5f Mon Sep 17 00:00:00 2001
From: Louis Charette <lcharette@users.noreply.github.com>
Date: Mon, 7 Oct 2024 19:42:54 -0400
Subject: [PATCH 2/2] Update docs.md

---
 pages/10.users/01.user-accounts/docs.md | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/pages/10.users/01.user-accounts/docs.md b/pages/10.users/01.user-accounts/docs.md
index 5279b70e..2352b452 100644
--- a/pages/10.users/01.user-accounts/docs.md
+++ b/pages/10.users/01.user-accounts/docs.md
@@ -232,7 +232,9 @@ class UserActions {
 
     public function delete($userId) {
         $userModel = new User();
-        $user = $userModel->find($userId);
+        
+        //includes soft-deleted users
+        $user = $userModel->withTrashed()->find($userId);
 
         if(!$user) return;
         $user->forceDelete();