Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Producer Context #59

Open
Gobonoid opened this issue Jul 26, 2018 · 2 comments
Open

Message Producer Context #59

Gobonoid opened this issue Jul 26, 2018 · 2 comments
Labels
v2 Feature request/discussion for pubsub V2

Comments

@Gobonoid
Copy link

For easier extendability I think Put message should have signature like:

PutMessage(ctx context.Context, message pubsub.ProducerMessage) error {

With current implementation wrapping this method with per request or per action behaviors is imposible. Consumer does use context.

@Gobonoid Gobonoid changed the title Message sink PutMessage should take context as a parameter Message sink PutMessage could take context as a parameter Jul 26, 2018
@Gobonoid Gobonoid added the v2 Feature request/discussion for pubsub V2 label Jul 26, 2018
@JamieAP JamieAP changed the title Message sink PutMessage could take context as a parameter Message Producer Context Aug 16, 2018
@mjgarton
Copy link
Contributor

I see the need for this in the consumer case, where the message handling itself may block or take a long time. I'm wondering about the producer case though. Why would you expect this to block? Is it as simple as the broken being slow for some reason, or have I missed something bigger?

@mjgarton
Copy link
Contributor

This is addressed in substrate. : https://github.com/uw-labs/substrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Feature request/discussion for pubsub V2
Projects
None yet
Development

No branches or pull requests

2 participants