Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating a new client at every status check #72

Open
pedrovsg opened this issue Sep 20, 2018 · 2 comments
Open

creating a new client at every status check #72

pedrovsg opened this issue Sep 20, 2018 · 2 comments

Comments

@pedrovsg
Copy link

Seems we are always creating a new client every time.
I think we should do it only once.

client, err := sarama.NewClient(brokerAddrs, sarama.NewConfig())

@aneshas
Copy link

aneshas commented Feb 9, 2019

Would you guys accept a PR for this if it does turn out to introduce unnecessary overhead :) ?

@mjgarton
Copy link
Contributor

We'd consider it of course.

I should let you know though that go-pubsub developement is slowing somewhat now, due to https://github.com/uw-labs/substrate which is intented to eventually replace go-pubsub and address some of it's shortcomings, although substrate still has a few things missing at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants