You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #23 includes a modularization patch that has a dependency on XOM. Initially, the patch had a strict dependency on nu.xom, but as the result of a comment from @anthonyvdotbe I changed the requirement to static (i.e. optional). This is the most conservative thing to do right now but otherwise is formally wrong (because XOM objects are part of this library's public API) and defeats the purpose of a full modularization (the current setup is mostly equivalent to an automatic module name).
As a better solution, I suggest splitting the htmlparser.xom package to a different repository, and ship it as a different artifact (with different release cycles). As I believe that patches are better than words, I created that repository here:
A possible alternative would be to convert htmlparser to a modular Maven project (with a single Git repository but two artifacts being also created), however that would complicate the workflow for little to no benefit, and expose the project to a new category of Maven bugs (I mean bugs affecting modular builds only).
Thoughts?
The text was updated successfully, but these errors were encountered:
PR #23 includes a modularization patch that has a dependency on XOM. Initially, the patch had a strict dependency on
nu.xom
, but as the result of a comment from @anthonyvdotbe I changed the requirement tostatic
(i.e. optional). This is the most conservative thing to do right now but otherwise is formally wrong (because XOM objects are part of this library's public API) and defeats the purpose of a full modularization (the current setup is mostly equivalent to an automatic module name).As a better solution, I suggest splitting the
htmlparser.xom
package to a different repository, and ship it as a different artifact (with different release cycles). As I believe that patches are better than words, I created that repository here:https://github.com/carlosame/htmlparser-xom
and a
xom-removed
branch that removes the XOM support fromhtmlparser
(it starts from myvalidator-nu
branch that has the modularization patch):https://github.com/carlosame/htmlparser/tree/xom-removed
A possible alternative would be to convert
htmlparser
to a modular Maven project (with a single Git repository but two artifacts being also created), however that would complicate the workflow for little to no benefit, and expose the project to a new category of Maven bugs (I mean bugs affecting modular builds only).Thoughts?
The text was updated successfully, but these errors were encountered: