Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for exporting Kysely wrapped types #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

taro-kayo
Copy link

Close: #81

Added exportWrappedTypes option which enables exporting the Kysely wrapped types as described in the document.

@taro-kayo taro-kayo marked this pull request as ready for review October 28, 2023 08:37
@taro-kayo taro-kayo requested a review from valtyr as a code owner October 28, 2023 08:37
@valtyr
Copy link
Owner

valtyr commented Nov 1, 2023

This is awesome! I'm a bit afraid of having different naming standards based on an option, so I wonder if we should make this a breaking change instead (and bump the major version), use the 'Table' suffix on all table types, and just export these by default?

@taro-kayo
Copy link
Author

Thanks for reviewing!
I will leave that decision to you. 🙉
(I think it makes sense in both cases.)

If you decide to make this a breaking change (i.e. remove exportWrappedTypes), I can fix it that way in a couple of days.

@serhankileci
Copy link

Any news on this? I came to make a PR about this feature myself, it would be very convenient not having to Selectable<> prisma-kysely generated table types whenever we have to reference tables. Great library!

@anduong96
Copy link

@valtyr any update?

@JoseRoman
Copy link

This would be super helpful

@coji
Copy link

coji commented Mar 17, 2024

+1

@hyoretsu
Copy link

hyoretsu commented Mar 27, 2024

@valtyr just came across this, was resorting to use as unknown as Entity. Any news? (Or a warning in docs for people who aren't used to Kysely)

@emilio-toledo
Copy link

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrapped types are not generated as per kysely suggestion
8 participants